git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[RFC PATCH 0/3] replay: implement support for writing new objects to a pack

From
Taylor Blau <me@ttaylorr.com>
Date
Nov 7, 2023, 18:22 UTC
Message-ID
<cover.1699381371.git.me@ttaylorr.com>
In-Reply-To
<ZUpepnSCSxL8i96b@nand.local>

(Based on a combination of Christian's cc/git-replay and my tb/merge-tree-write-pack branches).

This RFC demonstrates extending the new `--write-pack` option that `merge-tree` recently learned to the `replay` builtin as well.

The approach is as follows:
  - write a pack out after each step in the replay operation, so that
    subsequent steps may see any new object(s) created during previous
    steps
  - combine those packs into one before migrating them back into the
    main object store

This is accomplished with a combination of the bulk-checkin and tmp-objdir APIs, with some minor modifications made to when we flush out and finalize bulk-checkin transactions.

The benefit to this approach is that we bound the number of inodes required per replayed commit to a constant (by default, 3: one for the .pack, one for the .idx, and another for the .rev file), instead of having each operation take an unbounded number of inodes proportional to the number of new objects created during that step. We also only migrate a single pack back to the main object store.

In other words, this makes the maximum number of inodes required by 'replay' grow proportional to the number of commits being replayed, instead of the number of new *objects* created as a result of the replay operation.

Taylor Blau (3):
  merge-ort.c: finalize ODB transactions after each step
  tmp-objdir: introduce `tmp_objdir_repack()`
  builtin/replay.c: introduce `--write-pack`
 Documentation/git-replay.txt |  4 ++++
 builtin/replay.c             | 18 ++++++++++++++++++
 merge-ort.c                  |  5 ++++-
 t/t3650-replay-basics.sh     | 37 ++++++++++++++++++++++++++++++++++++
 tmp-objdir.c                 | 13 +++++++++++++
 tmp-objdir.h                 |  6 ++++++
 6 files changed, 82 insertions(+), 1 deletion(-)
-- 
2.42.0.446.g0b9ef90488
Previous: Taylor BlauNext: Taylor Blau
Message 54 of 63 in “merge-ort: implement support for packing objects together”
  1. 0/7 merge-ort: implement support for packing objects togetherTaylor Blau, Oct 19, 2023
  2. 1/7 bulk-checkin: extract abstract `bulk_checkin_source`Taylor Blau, Oct 19, 2023
  3. Jeff KingOct 20, 2023
  4. Junio C HamanoOct 20, 2023
  5. 2/7 bulk-checkin: generify `stream_blob_to_pack()` for arbitrary typesTaylor Blau, Oct 19, 2023
  6. 3/7 bulk-checkin: refactor deflate routine to accept a `bulk_checkin_source`Taylor Blau, Oct 19, 2023
  7. 4/7 bulk-checkin: implement `SOURCE_INCORE` mode for `bulk_checkin_source`Taylor Blau, Oct 19, 2023
  8. Patrick SteinhardtOct 23, 2023
  9. Jeff KingOct 23, 2023
  10. Patrick SteinhardtOct 24, 2023
  11. Junio C HamanoOct 24, 2023
  12. 5/7 bulk-checkin: introduce `index_blob_bulk_checkin_incore()`Taylor Blau, Oct 19, 2023
  13. 6/7 bulk-checkin: introduce `index_tree_bulk_checkin_incore()`Taylor Blau, Oct 19, 2023
  14. 7/7 builtin/merge-tree.c: implement support for `--write-pack`Taylor Blau, Oct 19, 2023
  15. Junio C HamanoOct 19, 2023
  16. Jeff KingOct 20, 2023
  17. Junio C HamanoOct 20, 2023
  18. Patrick SteinhardtOct 23, 2023
  19. 0/5 merge-ort: implement support for packing objects togetherTaylor Blau, Oct 23, 2023
  20. 1/5 bulk-checkin: extract abstract `bulk_checkin_source`Taylor Blau, Oct 23, 2023
  21. Jeff KingOct 25, 2023
  22. Taylor BlauOct 25, 2023
  23. Junio C HamanoOct 27, 2023
  24. 2/5 bulk-checkin: generify `stream_blob_to_pack()` for arbitrary typesTaylor Blau, Oct 23, 2023
  25. 3/5 bulk-checkin: introduce `index_blob_bulk_checkin_incore()`Taylor Blau, Oct 23, 2023
  26. Patrick SteinhardtOct 25, 2023
  27. Taylor BlauOct 25, 2023
  28. Eric SunshineOct 25, 2023
  29. Patrick SteinhardtOct 26, 2023
  30. Elijah NewrenNov 11, 2023
  31. 4/5 bulk-checkin: introduce `index_tree_bulk_checkin_incore()`Taylor Blau, Oct 23, 2023
  32. 5/5 builtin/merge-tree.c: implement support for `--write-pack`Taylor Blau, Oct 23, 2023
  33. Patrick SteinhardtOct 25, 2023
  34. Taylor BlauOct 25, 2023
  35. Elijah NewrenNov 10, 2023
  36. Junio C HamanoNov 11, 2023
  37. Taylor BlauNov 11, 2023
  38. Taylor BlauNov 11, 2023
  39. Jeff KingNov 13, 2023
  40. Junio C HamanoNov 14, 2023
  41. Elijah NewrenNov 14, 2023
  42. Jeff KingNov 14, 2023
  43. Elijah NewrenNov 14, 2023
  44. Jeff KingNov 13, 2023
  45. Taylor BlauNov 13, 2023
  46. Elijah NewrenNov 14, 2023
  47. Jeff KingNov 14, 2023
  48. Jeff KingNov 14, 2023
  49. Junio C HamanoOct 23, 2023
  50. Johannes SchindelinNov 6, 2023
  51. Junio C HamanoNov 6, 2023
  52. Jeff KingNov 7, 2023
  53. Taylor BlauNov 7, 2023
  54. 0/3 replay: implement support for writing new objects to a packTaylor Blau, Nov 7, 2023
  55. 1/3 merge-ort.c: finalize ODB transactions after each stepTaylor Blau, Nov 7, 2023
  56. Elijah NewrenNov 11, 2023
  57. 2/3 tmp-objdir: introduce `tmp_objdir_repack()`Taylor Blau, Nov 7, 2023
  58. Patrick SteinhardtNov 8, 2023
  59. Taylor BlauNov 9, 2023
  60. 3/3 builtin/replay.c: introduce `--write-pack`Taylor Blau, Nov 7, 2023
  61. Elijah NewrenNov 11, 2023
  62. Elijah NewrenNov 11, 2023
  63. Patrick SteinhardtOct 25, 2023

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.