Re: [RFC PATCH 0/3] replay: implement support for writing new objects to a pack

From: Elijah Newren <newren@gmail.com>
Date: Nov 11, 2023, 04:04 UTC
Message-ID: <CABPp-BGy8tkDAfgdhP9+V1dNk8_J3fM6ykb18jO5O4MC0VwTQQ@mail.gmail.com>
In-Reply-To: <cover.1699381371.git.me@ttaylorr.com>

On Tue, Nov 7, 2023 at 10:22 AM Taylor Blau <me@ttaylorr.com> wrote:

Show 19 quoted lines

>
> (Based on a combination of Christian's cc/git-replay and my
> tb/merge-tree-write-pack branches).
>
> This RFC demonstrates extending the new `--write-pack` option that
> `merge-tree` recently learned to the `replay` builtin as well.
>
> The approach is as follows:
>
>   - write a pack out after each step in the replay operation, so that
>     subsequent steps may see any new object(s) created during previous
>     steps
>
>   - combine those packs into one before migrating them back into the
>     main object store
>
> This is accomplished with a combination of the bulk-checkin and
> tmp-objdir APIs, with some minor modifications made to when we flush out
> and finalize bulk-checkin transactions.

Just thought I'd note that I finished reading all of this series as well as the five-commit series it's based on. Just wanted to note that any commits I didn't comment on from either series looked good to me.