git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 0/3] gc: fix handling of crontab magic markers

From
MÅMartin Ågren <martin.agren@gmail.com>
Date
Dec 21, 2020, 21:26 UTC
Message-ID
<cover.1608585497.git.martin.agren@gmail.com>
This is a fix for a new bug in the v2.30 cycle:

`git maintenance [start|stop]` add and/or remove entries to/from the user's cron table. When inserting entries, we add magic "BEGIN" and "END" markers. When we later removes these entries, we remove everything from "BEGIN" to ... the end of file. A realistic scenario for hitting this bug is

  $ git maintenance start
  $ crontab -e # add stuff at the end of the file
  $ git maintenance stop
  $ crontab -l # stuff from above is gone

The second patch is the actual fix. The first patch is just a very minor fix to the documentation. The third patch future-proofs the magic markers, so that we can be reasonably sure that all future versions of Git stick to these strings.

Martin Ågren (3):
  git-maintenance.txt: add missing word
  gc: fix handling of crontab magic markers
  t7900-maintenance: test for magic markers
 Documentation/git-maintenance.txt |  2 +-
 t/t7900-maintenance.sh            | 16 ++++++++++++++++
 builtin/gc.c                      |  7 +++----
 3 files changed, 20 insertions(+), 5 deletions(-)
-- 
2.30.0.rc1
Next: Martin Ågren
Message 1 of 10 in “gc: fix handling of crontab magic markers”
  1. 0/3 gc: fix handling of crontab magic markersMartin Ågren, Dec 21, 2020
  2. 1/3 git-maintenance.txt: add missing wordMartin Ågren, Dec 21, 2020
  3. 3/3 t7900-maintenance: test for magic markersMartin Ågren, Dec 21, 2020
  4. 2/3 gc: fix handling of crontab magic markersMartin Ågren, Dec 21, 2020
  5. Junio C HamanoDec 22, 2020
  6. Junio C HamanoDec 22, 2020
  7. Eric SunshineDec 23, 2020
  8. Martin ÅgrenDec 23, 2020
  9. Junio C HamanoDec 23, 2020
  10. Derrick StoleeDec 21, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.