Re: [PATCH 0/3] gc: fix handling of crontab magic markers

From: Derrick Stolee <stolee@gmail.com>
Date: Dec 21, 2020, 21:54 UTC
Message-ID: <8ee65ef1-a68b-e881-70af-cb2a492331ca@gmail.com>
In-Reply-To: <cover.1608585497.git.martin.agren@gmail.com>

On 12/21/2020 4:26 PM, Martin Ågren wrote:

Show 17 quoted lines

> This is a fix for a new bug in the v2.30 cycle:
> 
> `git maintenance [start|stop]` add and/or remove entries to/from the
> user's cron table. When inserting entries, we add magic "BEGIN" and
> "END" markers. When we later removes these entries, we remove everything
> from "BEGIN" to ... the end of file. A realistic scenario for hitting
> this bug is
> 
>   $ git maintenance start
>   $ crontab -e # add stuff at the end of the file
>   $ git maintenance stop
>   $ crontab -l # stuff from above is gone
> 
> The second patch is the actual fix. The first patch is just a very minor
> fix to the documentation. The third patch future-proofs the magic
> markers, so that we can be reasonably sure that all future versions of
> Git stick to these strings.

Thank you for the attention to detail here. I think this series is succinct and completely correct. Apologies for missing the obvious "test after the region, too!"

Thanks, -Stolee