git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/3] gc: fix handling of crontab magic markers

From
Eric Sunshine <sunshine@sunshineco.com>
Date
Dec 23, 2020, 03:50 UTC
Message-ID
<CAPig+cRmatC0Q22XBBx-ouzNSn5uiarTes1tSehGZuBWucSt1g@mail.gmail.com>
In-Reply-To
<xmqqsg7xfoj9.fsf@gitster.c.googlers.com>
On Tue, Dec 22, 2020 at 5:47 PM Junio C Hamano <gitster@pobox.com> wrote:
Show 12 quoted lines
> Martin Ågren <martin.agren@gmail.com> writes:
> > +test_expect_success 'stop preserves surrounding schedule' '
> > +     echo "Crucial information!" >>cron.txt &&
> > +     GIT_TEST_CRONTAB="test-tool crontab cron.txt" git maintenance stop &&
>
> 31345d55 (maintenance: extract platform-specific scheduling,
> 2020-11-24) in ds/maintenance-part-4 needs to adjust this
> exported variable for the tests to pass in 'seen'
>
> Is it just the matter of replacing it with
>         GIT_TEST_MAINT_SCHEDULER="crontab:test-tool crontab ..."
> or is there more to it?

Yes, renaming GIT_TEST_CRONTAB to GIT_TEST_MAINT_SCHEDULER and prepending "crontab:" to the value should be sufficient (per the proposal by [1] and realization by [2]).

[1]: https://lore.kernel.org/git/X6+iJNYEbpQjHCb0@flurp.local/ [2]: https://lore.kernel.org/git/4807342b0019be29bb369ed3403a485f0ce9c15d.1605647598.git.gitgitgadget@gmail.com/

Previous: Junio C HamanoNext: Martin Ågren
Message 7 of 10 in “gc: fix handling of crontab magic markers”
  1. 0/3 gc: fix handling of crontab magic markersMartin Ågren, Dec 21, 2020
  2. 1/3 git-maintenance.txt: add missing wordMartin Ågren, Dec 21, 2020
  3. 3/3 t7900-maintenance: test for magic markersMartin Ågren, Dec 21, 2020
  4. 2/3 gc: fix handling of crontab magic markersMartin Ågren, Dec 21, 2020
  5. Junio C HamanoDec 22, 2020
  6. Junio C HamanoDec 22, 2020
  7. Eric SunshineDec 23, 2020
  8. Martin ÅgrenDec 23, 2020
  9. Junio C HamanoDec 23, 2020
  10. Derrick StoleeDec 21, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.