git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 0/3] Fix tests on Windows caused by random CRLF output

From
Johannes Sixt <j6t@kdbg.org>
Date
Oct 26, 2013, 19:17 UTC
Message-ID
<cover.1382814437.git.j6t@kdbg.org>

When git, the executable, invokes a bash script (hooks, scripted git commands, ...), bash writes its output with CRLF. This causes tests to fail because the expected output does not contain CR, only LF.

This fixes the tests by replacing test_cmp with a diff computation that disregards the CR.

Patch 1 replaces test_cmp with cmp when binary data is compared. Patch 2 is the actual fix. Patch 3 removes some work-arounds that are not necessary anymore.

Johannes Sixt (3):
  t5300-pack-object: do not compare binary data using test_cmp
  Windows: a test_cmp that is agnostic to random LF <> CRLF conversions
  tests: undo special treatment of CRLF for Windows
 t/lib-credential.sh          |  4 ---
 t/t5300-pack-object.sh       | 10 +++----
 t/t7407-submodule-foreach.sh |  4 ---
 t/t9001-send-email.sh        |  1 -
 t/test-lib-functions.sh      | 66 ++++++++++++++++++++++++++++++++++++++++++++
 t/test-lib.sh                |  1 +
 6 files changed, 72 insertions(+), 14 deletions(-)
-- 
1.8.4.33.gd68f7e8

-- 
-- 
*** Please reply-to-all at all times ***
*** (do not pretend to know who is subscribed and who is not) ***
*** Please avoid top-posting. ***
The msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free.

You received this message because you are subscribed to the Google
Groups "msysGit" group.
To post to this group, send email to msysgit@googlegroups.com
To unsubscribe from this group, send email to
msysgit+unsubscribe@googlegroups.com
For more options, and view previous threads, visit this group at
http://groups.google.com/group/msysgit?hl=en_US?hl=en

--- 
You received this message because you are subscribed to the Google Groups "msysGit" group.
To unsubscribe from this group and stop receiving emails from it, send an email to msysgit+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
Next: Johannes Sixt
Message 1 of 8 in “Fix tests on Windows caused by random CRLF output”
  1. 0/3 Fix tests on Windows caused by random CRLF outputJohannes Sixt, Oct 26, 2013
  2. 1/3 t5300-pack-object: do not compare binary data using test_cmpJohannes Sixt, Oct 26, 2013
  3. 2/3 Windows: a test_cmp that is agnostic to random LF <> CRLF conversionsJohannes Sixt, Oct 26, 2013
  4. Sebastian SchuberthNov 2, 2013
  5. Johannes SixtNov 2, 2013
  6. Sebastian SchuberthNov 2, 2013
  7. Johannes SixtNov 3, 2013
  8. 3/3 tests: undo special treatment of CRLF for WindowsJohannes Sixt, Oct 26, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.