Re: [PATCH 2/3] Windows: a test_cmp that is agnostic to random LF <> CRLF conversions
- From
Sebastian Schuberth <sschuberth@gmail.com>
- Date
- Nov 2, 2013, 20:47 UTC
- Message-ID
- <CAHGBnuOHHAZUD_1WWu+WrAYKB1f0BonztbAFzVqhxP0bjAkyfw@mail.gmail.com>
- In-Reply-To
- <52756332.50404@kdbg.org>
On Sat, Nov 2, 2013 at 9:40 PM, Johannes Sixt <j6t@kdbg.org> wrote:
Show 14 quoted lines
>>> In a number of tests, output that was produced by a shell script is >>> compared to expected output using test_cmp. Unfortunately, the MSYS >>> bash-- >>> when invoked via git, such as in hooks--converts LF to CRLF on output >>> (as produced by echo and printf), which leads to many false positives. >> >> As you correctly point out the LF vs. CRLF issues are caused by MSYS >> bash. Then why are the functions called mingw_* instead of msys_*? I'd >> prefer to make very clear that not MinGW but MSYS is the culprit >> concerning the LF vs. CRLF issues (and also the path mangling issues). > > It's a historical accident. We already have the prerequisite MINGW to > work around various annoyances, most of which are caused by MSYS bash. I > didn't want to invent a new prefix.
So maybe it's a good point now to also change the MINGW prerequisite name to MSYS as part of your patch, and then name the functions more appropriately?
-- Sebastian Schuberth -- -- *** Please reply-to-all at all times *** *** (do not pretend to know who is subscribed and who is not) *** *** Please avoid top-posting. *** The msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free. You received this message because you are subscribed to the Google Groups "msysGit" group. To post to this group, send email to msysgit@googlegroups.com To unsubscribe from this group, send email to msysgit+unsubscribe@googlegroups.com For more options, and view previous threads, visit this group at http://groups.google.com/group/msysgit?hl=en_US?hl=en --- You received this message because you are subscribed to the Google Groups "msysGit" group. To unsubscribe from this group and stop receiving emails from it, send an email to msysgit+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.