Re: [PATCH 2/3] Windows: a test_cmp that is agnostic to random LF <> CRLF conversions

From: Sebastian Schuberth <sschuberth@gmail.com>
Date: Nov 2, 2013, 20:33 UTC
Message-ID: <52756198.2070900@gmail.com>
In-Reply-To: <e64878fec3f026802e8d3958a1e6213428cab778.1382814437.git.j6t@kdbg.org>

On 26.10.2013 21:17, Johannes Sixt wrote:

> In a number of tests, output that was produced by a shell script is
> compared to expected output using test_cmp. Unfortunately, the MSYS bash--
> when invoked via git, such as in hooks--converts LF to CRLF on output
> (as produced by echo and printf), which leads to many false positives.

As you correctly point out the LF vs. CRLF issues are caused by MSYS bash. Then why are the functions called mingw_* instead of msys_*? I'd prefer to make very clear that not MinGW but MSYS is the culprit concerning the LF vs. CRLF issues (and also the path mangling issues).

-- 
Sebastian Schuberth

-- 
-- 
*** Please reply-to-all at all times ***
*** (do not pretend to know who is subscribed and who is not) ***
*** Please avoid top-posting. ***
The msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free.

You received this message because you are subscribed to the Google
Groups "msysGit" group.
To post to this group, send email to msysgit@googlegroups.com
To unsubscribe from this group, send email to
msysgit+unsubscribe@googlegroups.com
For more options, and view previous threads, visit this group at
http://groups.google.com/group/msysgit?hl=en_US?hl=en

--- 
You received this message because you are subscribed to the Google Groups "msysGit" group.
To unsubscribe from this group and stop receiving emails from it, send an email to msysgit+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.