git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 0/3] add: remove Perl version of "git add -[pi]"

From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date
Feb 3, 2023, 16:30 UTC
Message-ID
<cover-0.3-00000000000-20230203T125859Z-avarab@gmail.com>

The v2.37.0 we've made the built-in version of "git add -i" and "git add -p" the default, after having had the built-in version optionally available since v2.25.0.

With this the time we kept around the legacy implementation falls between the time we kept the similar "rebase" and "stash" implementations.

After it was made the default we had a next-release regression fix[1], but haven't had any issues since then. Any outstanding bugs in it are something we'd fix in the C code, not something where users are likely to want an escape hatch to scramble back to the Perl implementation.

Branch & CI for this available at: https://github.com/avar/git/tree/avar/nuke-perl-add--interactive

1. 4788e8b2569 (add --interactive: allow `update` to stage deleted
   files, 2022-06-28)
   https://github.com/msys2/MSYS2-packages/issues/3066
Ævar Arnfjörð Bjarmason (3):
  add: remove "add.interactive.useBuiltin" & Perl "git add--interactive"
  add API: remove run_add_interactive() wrapper function
  docs & comments: replace mentions of "git-add--interactive.perl"
 .gitignore                   |    1 -
 Documentation/config/add.txt |    7 +-
 Documentation/git-add.txt    |    6 +-
 Makefile                     |    1 -
 builtin/add.c                |   61 +-
 builtin/checkout.c           |   12 +-
 builtin/clean.c              |    2 +-
 builtin/reset.c              |    4 +-
 builtin/stash.c              |    3 +-
 ci/run-build-and-tests.sh    |    1 -
 commit.h                     |    2 -
 git-add--interactive.perl    | 1920 ----------------------------------
 pathspec.c                   |    2 +-
 t/README                     |    4 -
 t/t2016-checkout-patch.sh    |    6 -
 t/t3701-add-interactive.sh   |   29 +-
 t/t6132-pathspec-exclude.sh  |    6 +-
 t/test-lib.sh                |    4 -
 18 files changed, 49 insertions(+), 2022 deletions(-)
 delete mode 100755 git-add--interactive.perl
-- 
2.39.1.1397.gbe42486b8a4
Next: Ævar Arnfjörð Bjarmason
Message 1 of 13 in “add: remove Perl version of "git add -[pi]"”
  1. 0/3 add: remove Perl version of "git add -[pi]"Ævar Arnfjörð Bjarmason, Feb 3, 2023
  2. 2/3 add API: remove run_add_interactive() wrapper functionÆvar Arnfjörð Bjarmason, Feb 3, 2023
  3. 3/3 docs & comments: replace mentions of "git-add--interactive.perl"Ævar Arnfjörð Bjarmason, Feb 3, 2023
  4. 1/3 add: remove "add.interactive.useBuiltin" & Perl "git add--interactive"Ævar Arnfjörð Bjarmason, Feb 3, 2023
  5. Philippe BlainFeb 6, 2023
  6. Jeff KingFeb 3, 2023
  7. Junio C HamanoFeb 3, 2023
  8. 0/3 add: remove Perl version of "git add -[pi]"Ævar Arnfjörð Bjarmason, Feb 6, 2023
  9. 1/3 add: remove "add.interactive.useBuiltin" & Perl "git add--interactive"Ævar Arnfjörð Bjarmason, Feb 6, 2023
  10. 3/3 docs & comments: replace mentions of "git-add--interactive.perl"Ævar Arnfjörð Bjarmason, Feb 6, 2023
  11. 2/3 add API: remove run_add_interactive() wrapper functionÆvar Arnfjörð Bjarmason, Feb 6, 2023
  12. Junio C HamanoFeb 6, 2023
  13. Phillip WoodFeb 7, 2023

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.