Re: [PATCH 0/3] add: remove Perl version of "git add -[pi]"

From: Jeff King <peff@peff.net>
Date: Feb 3, 2023, 16:48 UTC
Message-ID: <Y906yEGFEIglRyVb@coredump.intra.peff.net>
In-Reply-To: <cover-0.3-00000000000-20230203T125859Z-avarab@gmail.com>

On Fri, Feb 03, 2023 at 05:30:01PM +0100, Ævar Arnfjörð Bjarmason wrote:

> After it was made the default we had a next-release regression fix[1],
> but haven't had any issues since then. Any outstanding bugs in it are
> something we'd fix in the C code, not something where users are likely
> to want an escape hatch to scramble back to the Perl implementation.

I'm in favor of dropping the perl version, but note that this paragraph isn't quite accurate. There was at least one more regression after that, solved by fb094cb583 (Merge branch 'js/add-p-diff-parsing-fix', 2022-09-09).

I'd probably leave the final decision on its status to Johannes. This is (I think) the last time we discussed it:

  https://lore.kernel.org/git/rsrn5988-37n4-7q45-s1o9-6n40rropp120@tzk.qr/

That was 6 months ago, so maybe it's time now.

-Peff