git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 0/3] add: remove Perl version of "git add -[pi]"

From
PWPhillip Wood <phillip.wood123@gmail.com>
Date
Feb 7, 2023, 10:21 UTC
Message-ID
<25ce4764-177b-c961-9df2-1543a4e9e149@dunelm.org.uk>
In-Reply-To
<cover-v2-0.3-00000000000-20230206T225639Z-avarab@gmail.com>
Hi Ævar
On 06/02/2023 22:58, Ævar Arnfjörð Bjarmason wrote:
Show 11 quoted lines
> We've given the "git add -i" migration away from Perl to a built-in
> enough time to remove the old Perl code.
> 
> For v1, see:
> https://lore.kernel.org/git/cover-0.3-00000000000-20230203T125859Z-avarab@gmail.com/
> 
> Branch & CI for this at:
> https://github.com/avar/git/tree/avar/nuke-perl-add--interactive-2
> 
> The only change from v1 is to squash in a suggested change from
> Philippe Blain, thanks!

Thanks for doing this, it will be nice to only have a single implementation to worry about.

Best Wishes
Phillip
Show 49 quoted lines
> Ævar Arnfjörð Bjarmason (3):
>    add: remove "add.interactive.useBuiltin" & Perl "git add--interactive"
>    add API: remove run_add_interactive() wrapper function
>    docs & comments: replace mentions of "git-add--interactive.perl"
> 
>   .gitignore                   |    1 -
>   Documentation/config/add.txt |    7 +-
>   Documentation/git-add.txt    |    6 +-
>   INSTALL                      |    2 +-
>   Makefile                     |    1 -
>   builtin/add.c                |   61 +-
>   builtin/checkout.c           |   12 +-
>   builtin/clean.c              |    2 +-
>   builtin/reset.c              |    4 +-
>   builtin/stash.c              |    3 +-
>   ci/run-build-and-tests.sh    |    1 -
>   commit.h                     |    2 -
>   git-add--interactive.perl    | 1920 ----------------------------------
>   pathspec.c                   |    2 +-
>   t/README                     |    4 -
>   t/t2016-checkout-patch.sh    |    6 -
>   t/t3701-add-interactive.sh   |   29 +-
>   t/t6132-pathspec-exclude.sh  |    6 +-
>   t/test-lib.sh                |    4 -
>   19 files changed, 50 insertions(+), 2023 deletions(-)
>   delete mode 100755 git-add--interactive.perl
> 
> Range-diff against v1:
> 1:  f39dde93011 ! 1:  71c7922b25f add: remove "add.interactive.useBuiltin" & Perl "git add--interactive"
>      @@ Documentation/config/add.txt: add.ignore-errors (deprecated)::
>       +	interactive mode, which then became the default in Git
>       +	versions v2.37.0 to v2.39.0.
>       
>      + ## INSTALL ##
>      +@@ INSTALL: Issues of note:
>      + 	  for everyday use (e.g. "bisect", "request-pull").
>      +
>      + 	- "Perl" version 5.8 or later is needed to use some of the
>      +-	  features (e.g. preparing a partial commit using "git add -i/-p",
>      ++	  features (e.g. sending patches using "git send-email",
>      + 	  interacting with svn repositories with "git svn").  If you can
>      + 	  live without these, use NO_PERL.  Note that recent releases of
>      + 	  Redhat/Fedora are reported to ship Perl binary package with some
>      +
>        ## Makefile ##
>       @@ Makefile: SCRIPT_LIB += git-mergetool--lib
>        SCRIPT_LIB += git-sh-i18n
> 2:  fb0dafaf4a4 = 2:  9299f22cc2c add API: remove run_add_interactive() wrapper function
> 3:  6ee56de1371 = 3:  09bece75c22 docs & comments: replace mentions of "git-add--interactive.perl"
Previous: Junio C Hamano
Message 13 of 13 in “add: remove Perl version of "git add -[pi]"”
  1. 0/3 add: remove Perl version of "git add -[pi]"Ævar Arnfjörð Bjarmason, Feb 3, 2023
  2. 2/3 add API: remove run_add_interactive() wrapper functionÆvar Arnfjörð Bjarmason, Feb 3, 2023
  3. 3/3 docs & comments: replace mentions of "git-add--interactive.perl"Ævar Arnfjörð Bjarmason, Feb 3, 2023
  4. 1/3 add: remove "add.interactive.useBuiltin" & Perl "git add--interactive"Ævar Arnfjörð Bjarmason, Feb 3, 2023
  5. Philippe BlainFeb 6, 2023
  6. Jeff KingFeb 3, 2023
  7. Junio C HamanoFeb 3, 2023
  8. 0/3 add: remove Perl version of "git add -[pi]"Ævar Arnfjörð Bjarmason, Feb 6, 2023
  9. 1/3 add: remove "add.interactive.useBuiltin" & Perl "git add--interactive"Ævar Arnfjörð Bjarmason, Feb 6, 2023
  10. 3/3 docs & comments: replace mentions of "git-add--interactive.perl"Ævar Arnfjörð Bjarmason, Feb 6, 2023
  11. 2/3 add API: remove run_add_interactive() wrapper functionÆvar Arnfjörð Bjarmason, Feb 6, 2023
  12. Junio C HamanoFeb 6, 2023
  13. Phillip WoodFeb 7, 2023

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.