git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 0/3] strbuf.[ch]: add STRBUF_HINT_SIZE, don't hardcode 8192

From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date
Jul 7, 2021, 10:38 UTC
Message-ID
<cover-0.3-00000000000-20210707T103712Z-avarab@gmail.com>

A rather trivial cleanup series to avoid hardcoding 8192 in N places in strbuf.[ch], instead we add a STRBUF_HINT_SIZE macro. Then make strbuf_fread() take a "hint" instead of "size" (like most similar functions) so we can pass a size of "0" meaning the default hint to it.

Ævar Arnfjörð Bjarmason (3):
  strbuf.[ch]: add STRBUF_HINT_SIZE macro = 8192
  strbuf.h API users: don't hardcode 8192, use STRBUF_HINT_SIZE
  strbuf.[ch]: make strbuf_fread() take hint, not size
 builtin/am.c |  4 ++--
 cache-tree.c |  2 +-
 commit.c     |  2 +-
 strbuf.c     |  9 +++++----
 strbuf.h     | 14 +++++++++++++-
 5 files changed, 22 insertions(+), 9 deletions(-)
-- 
2.32.0.636.g43e71d69cff
Next: Ævar Arnfjörð Bjarmason
Message 1 of 12 in “strbuf.[ch]: add STRBUF_HINT_SIZE, don't hardcode 8192”
  1. 0/3 strbuf.[ch]: add STRBUF_HINT_SIZE, don't hardcode 8192Ævar Arnfjörð Bjarmason, Jul 7, 2021
  2. 1/3 strbuf.[ch]: add STRBUF_HINT_SIZE macro = 8192Ævar Arnfjörð Bjarmason, Jul 7, 2021
  3. Junio C HamanoJul 7, 2021
  4. 2/3 strbuf.h API users: don't hardcode 8192, use STRBUF_HINT_SIZEÆvar Arnfjörð Bjarmason, Jul 7, 2021
  5. Eric SunshineJul 7, 2021
  6. Junio C HamanoJul 7, 2021
  7. Junio C HamanoJul 7, 2021
  8. Randall S. BeckerJul 7, 2021
  9. Jeff KingJul 12, 2021
  10. 3/3 strbuf.[ch]: make strbuf_fread() take hint, not sizeÆvar Arnfjörð Bjarmason, Jul 7, 2021
  11. Han-Wen NienhuysJul 7, 2021
  12. Junio C HamanoJul 7, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.