git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH tg/add-chmod+x-fix 1/2] t3700-add: create subdirectory gently

From
Johannes Sixt <j6t@kdbg.org>
Date
Sep 20, 2016, 06:16 UTC
Message-ID
<cee3c784-8f03-c524-2f67-d35cb3755a41@kdbg.org>

The subdirectory 'sub' is created early in the test file. Later, a test case removes it during its clean-up actions. However, this test case is protected by POSIXPERM. Consequently, 'sub' remains when the POSIXPERM prerequisite is not satisfied. Later, a recently introduced test case creates 'sub' again. Use -p with mkdir so that it does not fail if 'sub' already exists.

Signed-off-by: Johannes Sixt <j6t@kdbg.org>
---
 t/t3700-add.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/t/t3700-add.sh b/t/t3700-add.sh
index 0a962a6..16ab2da 100755
--- a/t/t3700-add.sh
+++ b/t/t3700-add.sh
@@ -380,7 +380,7 @@ test_expect_success 'no file status change if no pathspec is given' '
 '
 
 test_expect_success 'no file status change if no pathspec is given in subdir' '
-	mkdir sub &&
+	mkdir -p sub &&
 	(
 		cd sub &&
 		>sub-foo1 &&
-- 
2.10.0.85.gea34e30
Next: Johannes Sixt
Message 1 of 11 in “t3700-add: create subdirectory gently”
  1. 1/2 t3700-add: create subdirectory gentlyJohannes Sixt, Sep 20, 2016
  2. 2/2 t3700-add: protect one --chmod=+x test with POSIXPERMJohannes Sixt, Sep 20, 2016
  3. Thomas GummererSep 20, 2016
  4. Junio C HamanoSep 21, 2016
  5. Johannes SixtSep 21, 2016
  6. Junio C HamanoSep 21, 2016
  7. Johannes SixtSep 21, 2016
  8. Junio C HamanoSep 21, 2016
  9. Johannes SixtSep 22, 2016
  10. Thomas GummererSep 22, 2016
  11. Thomas GummererSep 20, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.