Re: [PATCH tg/add-chmod+x-fix 2/2] t3700-add: protect one --chmod=+x test with POSIXPERM

From: Johannes Sixt <j6t@kdbg.org>
Date: Sep 21, 2016, 20:58 UTC
Message-ID: <c3aefd9d-b794-21a1-619e-bce6a3c2cf47@kdbg.org>
In-Reply-To: <xmqqa8f16kup.fsf@gitster.mtv.corp.google.com>

Am 21.09.2016 um 22:47 schrieb Junio C Hamano:

Show 10 quoted lines

> -test_expect_success 'file status is changed after git add --chmod=+x' '
> -	echo "AM foo4" >expected &&
> +test_expect_success 'git add --chmod=[+-]x changes index with newly added file' '
>  	echo foo >foo4 &&
>  	git add foo4 &&
>  	git add --chmod=+x foo4 &&
> -	git status -s foo4 >actual &&
> -	test_cmp expected actual
> +	test_mode_in_index 100755 foo4
>  '

No, that's redundant. There are plenty of other test cases that check for this. You could just remove the case.

But I came to a different conclusion as I said in a message that crossed yours. I hope Thomas can pick up the baton again.

-- Hannes