git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH tg/add-chmod+x-fix 2/2] t3700-add: protect one --chmod=+x test with POSIXPERM

From
Johannes Sixt <j6t@kdbg.org>
Date
Sep 20, 2016, 06:18 UTC
Message-ID
<5effaf36-d017-3ff1-1de1-d9b303c04f23@kdbg.org>
In-Reply-To
<cee3c784-8f03-c524-2f67-d35cb3755a41@kdbg.org>

A recently introduced test checks the result of 'git status' after setting the executable bit on a file. This check does not yield the expected result when the filesystem does not support the executable bit (and core.filemode is false). Skip the test case.

Signed-off-by: Johannes Sixt <j6t@kdbg.org>
---
 I am surprised that add --chmod=+x changes only the index, but not
 the file on disk!?!
 t/t3700-add.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/t/t3700-add.sh b/t/t3700-add.sh
index 16ab2da..13e0dd2 100755
--- a/t/t3700-add.sh
+++ b/t/t3700-add.sh
@@ -361,7 +361,7 @@ test_expect_success 'git add --chmod=[+-]x changes index with already added file
 	test_mode_in_index 100644 xfoo3
 '
 
-test_expect_success 'file status is changed after git add --chmod=+x' '
+test_expect_success POSIXPERM 'file status is changed after git add --chmod=+x' '
 	echo "AM foo4" >expected &&
 	echo foo >foo4 &&
 	git add foo4 &&
-- 
2.10.0.85.gea34e30
Previous: Johannes SixtNext: Thomas Gummerer
Message 2 of 11 in “t3700-add: create subdirectory gently”
  1. 1/2 t3700-add: create subdirectory gentlyJohannes Sixt, Sep 20, 2016
  2. 2/2 t3700-add: protect one --chmod=+x test with POSIXPERMJohannes Sixt, Sep 20, 2016
  3. Thomas GummererSep 20, 2016
  4. Junio C HamanoSep 21, 2016
  5. Johannes SixtSep 21, 2016
  6. Junio C HamanoSep 21, 2016
  7. Johannes SixtSep 21, 2016
  8. Junio C HamanoSep 21, 2016
  9. Johannes SixtSep 22, 2016
  10. Thomas GummererSep 22, 2016
  11. Thomas GummererSep 20, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.