git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 3/5] date.c::time_to_tm: use reentrant gmtime_r(3)

From
Doan Tran Cong Danh <congdanhqx@gmail.com>
Date
Nov 27, 2019, 15:13 UTC
Message-ID
<ce7fe7bcf363826b8f67c91d7300eb0158091752.1574867409.git.congdanhqx@gmail.com>
In-Reply-To
<cover.1574867409.git.congdanhqx@gmail.com>
Signed-off-by: Doan Tran Cong Danh <congdanhqx@gmail.com>
---
 date.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/date.c b/date.c
index ca71736a9f..b0d9a8421d 100644
--- a/date.c
+++ b/date.c
@@ -64,10 +64,10 @@ static time_t gm_time_t(timestamp_t time, int tz)
  * thing, which means that tz -0100 is passed in as the integer -100,
  * even though it means "sixty minutes off"
  */
-static struct tm *time_to_tm(timestamp_t time, int tz)
+static struct tm *time_to_tm(timestamp_t time, int tz, struct tm *tm)
 {
 	time_t t = gm_time_t(time, tz);
-	return gmtime(&t);
+	return gmtime_r(&t, tm);
 }
 
 static struct tm *time_to_tm_local(timestamp_t time, struct tm *tm)
@@ -321,9 +321,9 @@ const char *show_date(timestamp_t time, int tz, const struct date_mode *mode)
 	if (mode->local)
 		tm = time_to_tm_local(time, &tmbuf);
 	else
-		tm = time_to_tm(time, tz);
+		tm = time_to_tm(time, tz, &tmbuf);
 	if (!tm) {
-		tm = time_to_tm(0, 0);
+		tm = time_to_tm(0, 0, &tmbuf);
 		tz = 0;
 	}
 
-- 
2.24.0.158.gd77a74f4dd.dirty
Previous: Doan Tran Cong DanhNext: Doan Tran Cong Danh
Message 4 of 15 in “drop non-reentrant time usage”
  1. 0/5 drop non-reentrant time usageDoan Tran Cong Danh, Nov 27, 2019
  2. 1/5 date.c::datestamp: switch to reentrant localtime_rDoan Tran Cong Danh, Nov 27, 2019
  3. 2/5 date.c::time_to_tm_local: use reentrant localtime_r(3)Doan Tran Cong Danh, Nov 27, 2019
  4. 3/5 date.c::time_to_tm: use reentrant gmtime_r(3)Doan Tran Cong Danh, Nov 27, 2019
  5. 4/5 archive-zip: use reentrant localtime_r(3)Doan Tran Cong Danh, Nov 27, 2019
  6. 5/5 mingw: use {gm,local}time_s as backend for {gm,local}time_rDoan Tran Cong Danh, Nov 27, 2019
  7. Johannes SchindelinNov 27, 2019
  8. Johannes SchindelinNov 27, 2019
  9. Danh DoanNov 28, 2019
  10. Jeff KingNov 27, 2019
  11. Danh DoanNov 28, 2019
  12. 0/3 Phase out non-reentrant time functionsDoan Tran Cong Danh, Nov 28, 2019
  13. 1/3 date.c: switch to reentrant {gm,local}time_rDoan Tran Cong Danh, Nov 28, 2019
  14. 2/3 archive-zip.c: switch to reentrant localtime_rDoan Tran Cong Danh, Nov 28, 2019
  15. 3/3 mingw: use {gm,local}time_s as backend for {gm,local}time_rDoan Tran Cong Danh, Nov 28, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.