git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/5] drop non-reentrant time usage

From
Danh Doan <congdanhqx@gmail.com>
Date
Nov 28, 2019, 12:16 UTC
Message-ID
<20191128121613.GC9067@danh.dev>
In-Reply-To
<20191127162930.GC30581@sigill.intra.peff.net>
On 2019-11-27 11:29:30-0500, Jeff King <peff@peff.net> wrote:
Show 19 quoted lines
> On Wed, Nov 27, 2019 at 10:13:16PM +0700, Doan Tran Cong Danh wrote:
> 
> > gmtime/localtime is considered unsafe in multithread environment.
> > 
> > git was started as single-thread application, but we have some
> > multi-thread code, right now.
> > 
> > replace all usage of gmtime/localtime by their respective reentrant ones.
> 
> I think this is a good change.
> 
> A minor point, but I think it may be simpler if the first four were just
> a single patch. There's no rationale given at all in the 3rd and 4th
> ones. Which is because you already explained it in patch 1, but that
> won't help somebody who digs up the commit via "git blame".
> 
> So I think they either ought to be one patch, or they should repeat the
> rationale (I'd probably go with the first, but I could live with the
> second).

I'll merge first three into one since both of them are in date.c, the 4th one changed another file.

-- 
Danh
Previous: Jeff KingNext: Doan Tran Cong Danh
Message 11 of 15 in “drop non-reentrant time usage”
  1. 0/5 drop non-reentrant time usageDoan Tran Cong Danh, Nov 27, 2019
  2. 1/5 date.c::datestamp: switch to reentrant localtime_rDoan Tran Cong Danh, Nov 27, 2019
  3. 2/5 date.c::time_to_tm_local: use reentrant localtime_r(3)Doan Tran Cong Danh, Nov 27, 2019
  4. 3/5 date.c::time_to_tm: use reentrant gmtime_r(3)Doan Tran Cong Danh, Nov 27, 2019
  5. 4/5 archive-zip: use reentrant localtime_r(3)Doan Tran Cong Danh, Nov 27, 2019
  6. 5/5 mingw: use {gm,local}time_s as backend for {gm,local}time_rDoan Tran Cong Danh, Nov 27, 2019
  7. Johannes SchindelinNov 27, 2019
  8. Johannes SchindelinNov 27, 2019
  9. Danh DoanNov 28, 2019
  10. Jeff KingNov 27, 2019
  11. Danh DoanNov 28, 2019
  12. 0/3 Phase out non-reentrant time functionsDoan Tran Cong Danh, Nov 28, 2019
  13. 1/3 date.c: switch to reentrant {gm,local}time_rDoan Tran Cong Danh, Nov 28, 2019
  14. 2/3 archive-zip.c: switch to reentrant localtime_rDoan Tran Cong Danh, Nov 28, 2019
  15. 3/3 mingw: use {gm,local}time_s as backend for {gm,local}time_rDoan Tran Cong Danh, Nov 28, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.