git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 5/5] mingw: use {gm,local}time_s as backend for {gm,local}time_r

From
Danh Doan <congdanhqx@gmail.com>
Date
Nov 28, 2019, 12:05 UTC
Message-ID
<20191128120533.GB9067@danh.dev>
In-Reply-To
<nycvar.QRO.7.76.6.1911272038430.31080@tvgsbejvaqbjf.bet>
On 2019-11-27 20:39:27+0100, Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:
Show 16 quoted lines
> Hi Danh,
> 
> On Wed, 27 Nov 2019, Doan Tran Cong Danh wrote:
> 
> > diff --git a/compat/mingw.c b/compat/mingw.c
> > index fe609239dd..7b21f4eee5 100644
> > --- a/compat/mingw.c
> > +++ b/compat/mingw.c
> > @@ -1,6 +1,7 @@
> >  #include "../git-compat-util.h"
> >  #include "win32.h"
> >  #include <conio.h>
> > +#include <errno.h>
> 
> I actually overlooked this. Please drop this hunk, it should not be needed
> (and might break things in the MSVC build).

Oops, originally, I intended to reset errno after {gm,local}time_s Found out it's unneccessary later but I forgot to drop this hunk. I'll fix it.

-- 
Danh
Previous: Johannes SchindelinNext: Jeff King
Message 9 of 15 in “drop non-reentrant time usage”
  1. 0/5 drop non-reentrant time usageDoan Tran Cong Danh, Nov 27, 2019
  2. 1/5 date.c::datestamp: switch to reentrant localtime_rDoan Tran Cong Danh, Nov 27, 2019
  3. 2/5 date.c::time_to_tm_local: use reentrant localtime_r(3)Doan Tran Cong Danh, Nov 27, 2019
  4. 3/5 date.c::time_to_tm: use reentrant gmtime_r(3)Doan Tran Cong Danh, Nov 27, 2019
  5. 4/5 archive-zip: use reentrant localtime_r(3)Doan Tran Cong Danh, Nov 27, 2019
  6. 5/5 mingw: use {gm,local}time_s as backend for {gm,local}time_rDoan Tran Cong Danh, Nov 27, 2019
  7. Johannes SchindelinNov 27, 2019
  8. Johannes SchindelinNov 27, 2019
  9. Danh DoanNov 28, 2019
  10. Jeff KingNov 27, 2019
  11. Danh DoanNov 28, 2019
  12. 0/3 Phase out non-reentrant time functionsDoan Tran Cong Danh, Nov 28, 2019
  13. 1/3 date.c: switch to reentrant {gm,local}time_rDoan Tran Cong Danh, Nov 28, 2019
  14. 2/3 archive-zip.c: switch to reentrant localtime_rDoan Tran Cong Danh, Nov 28, 2019
  15. 3/3 mingw: use {gm,local}time_s as backend for {gm,local}time_rDoan Tran Cong Danh, Nov 28, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.