git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 3/5] refs/files: stop using `the_repository`

From
Patrick Steinhardt <ps@pks.im>
Date
Jul 30, 2024, 05:22 UTC
Message-ID
<cd51e9694d20e70b4c95a7ab8aee65e43c69cbe1.1722316795.git.ps@pks.im>
In-Reply-To
<cover.1722316795.git.ps@pks.im>

Convert the files ref backend to stop using `the_repository` in favor of the repo that gets passed in via `struct ref_store`.

Signed-off-by: Patrick Steinhardt <ps@pks.im>
---
 refs/files-backend.c | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/refs/files-backend.c b/refs/files-backend.c
index 3437c79699..c73f95ecf2 100644
--- a/refs/files-backend.c
+++ b/refs/files-backend.c
@@ -1,5 +1,3 @@
-#define USE_THE_REPOSITORY_VARIABLE
-
 #include "../git-compat-util.h"
 #include "../copy.h"
 #include "../environment.h"
@@ -248,7 +246,7 @@ static void loose_fill_ref_dir_regular_file(struct files_ref_store *refs,
 
 	if (!refs_resolve_ref_unsafe(&refs->base, refname, RESOLVE_REF_READING,
 				     &oid, &flag)) {
-		oidclr(&oid, the_repository->hash_algo);
+		oidclr(&oid, refs->base.repo->hash_algo);
 		flag |= REF_ISBROKEN;
 	} else if (is_null_oid(&oid)) {
 		/*
@@ -265,7 +263,7 @@ static void loose_fill_ref_dir_regular_file(struct files_ref_store *refs,
 	if (check_refname_format(refname, REFNAME_ALLOW_ONELEVEL)) {
 		if (!refname_is_safe(refname))
 			die("loose refname is dangerous: %s", refname);
-		oidclr(&oid, the_repository->hash_algo);
+		oidclr(&oid, refs->base.repo->hash_algo);
 		flag |= REF_BAD_NAME | REF_ISBROKEN;
 	}
 	add_entry_to_dir(dir, create_ref_entry(refname, &oid, flag));
@@ -1154,7 +1152,7 @@ static struct ref_lock *lock_ref_oid_basic(struct files_ref_store *refs,
 
 	if (!refs_resolve_ref_unsafe(&refs->base, lock->ref_name, 0,
 				     &lock->old_oid, NULL))
-		oidclr(&lock->old_oid, the_repository->hash_algo);
+		oidclr(&lock->old_oid, refs->base.repo->hash_algo);
 	goto out;
 
  error_return:
-- 
2.46.0.rc1.dirty
Previous: Patrick SteinhardtNext: Patrick Steinhardt
Message 4 of 12 in “refs: stop using `the_repository`”
  1. 0/5 refs: stop using `the_repository`Patrick Steinhardt, Jul 30, 2024
  2. 1/5 refs: stop using `the_repository`Patrick Steinhardt, Jul 30, 2024
  3. 2/5 refs/files: stop using `the_repository` in `parse_loose_ref_contents()`Patrick Steinhardt, Jul 30, 2024
  4. 3/5 refs/files: stop using `the_repository`Patrick Steinhardt, Jul 30, 2024
  5. 4/5 refs/packed: stop using `the_repository`Patrick Steinhardt, Jul 30, 2024
  6. Karthik NayakJul 30, 2024
  7. Patrick SteinhardtJul 31, 2024
  8. 5/5 refs/reftable: stop using `the_repository`Patrick Steinhardt, Jul 30, 2024
  9. Karthik NayakJul 30, 2024
  10. Patrick SteinhardtJul 31, 2024
  11. James LiuJul 31, 2024
  12. Patrick SteinhardtJul 31, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.