Re: [PATCH 0/5] refs: stop using `the_repository`

From: Patrick Steinhardt <ps@pks.im>
Date: Jul 31, 2024, 05:06 UTC
Message-ID: <ZqnGPeaqsXd4GTGb@tanuki>
In-Reply-To: <D33BCEL5LQQ0.33TQBJ9KVBMBX@jamesliu.io>

On Wed, Jul 31, 2024 at 10:55:09AM +1000, James Liu wrote:

Show 13 quoted lines

> On Tue Jul 30, 2024 at 3:22 PM AEST, Patrick Steinhardt wrote:
> > Hi,
> >
> > this patch series removes use of `the_repository` in the refs subsystem
> > and drops the `USE_THE_REPOSITORY_VARIABLE` macro define from those
> > files.
> >
> > Patrick
> 
> Thanks Patrick, these improvements make sense to me.
> 
> Is there a priority order on removing `the_repository` from other parts
> of the codebase?

I was tackling the refs API because I knew that it was a "leaf" package that doesn't have a ton of dependencies on subsystems that may be using `the_repository` itself. So I guess that the order that makes most sense is from leaf subsystems up to the root such that we can adjust layer by layer.

Figuring out what those leaf subsystems are is a different story though. I typically tend to brute force it, see how far I get and if I succeed then I don't mention all the failed tries that led to the patch series ;) Over time you then get some intuition for which parts to handle next, even though I realize that this is not particularly useful as advice to somebody not that familiar with the codebase.

Patrick