Re: [PATCH 0/5] refs: stop using `the_repository`

From: Patrick Steinhardt <ps@pks.im>
Date: Jul 31, 2024, 05:01 UTC
Message-ID: <ZqnFKFoaodui2C-P@tanuki>
In-Reply-To: <CAOLa=ZR+2FV-pdk2nZ1vR5dUx3G2Ze8=18CUCn8r_JUXfvR6fQ@mail.gmail.com>

On Tue, Jul 30, 2024 at 07:26:50AM -0400, Karthik Nayak wrote:

Show 13 quoted lines

> Patrick Steinhardt <ps@pks.im> writes:
> 
> > Hi,
> >
> > this patch series removes use of `the_repository` in the refs subsystem
> > and drops the `USE_THE_REPOSITORY_VARIABLE` macro define from those
> > files.
> >
> 
> So the idea is to slowly cleanup usages of `the_repository` and the
> `USE_THE_REPOSITORY_VARIABLE` macro acts as a check for this. I think
> the changes look great. I even ran clang-format on this series and apart
> from line wrap suggestions, there were no issues.

Exactly. One intent is to demonstrate to reviewers that a file actually got rid of `the_repository`. The second intent is to hide away APIs that have an implicit dependency on `the_repository`, which would be easy to miss otherwise.

The second part is not perfect because we only hide away a subset of interfaces. That part can be extended over time as required though.

Patrick