Re: [PATCH v4 2/6] t6030-bisect-porcelain: add test for bisect visualize
- From
Bagas Sanjaya <bagasdotme@gmail.com>
- Date
- Aug 17, 2021, 09:03 UTC
- Message-ID
- <cca9771b-035e-0aca-bcf2-115f7af364e4@gmail.com>
- In-Reply-To
- <20210817081458.53136-3-mirucam@gmail.com>
On 17/08/21 15.14, Miriam Rubio wrote:
Show 24 quoted lines
> Add a test to control breakages in bisect visualize command. > > Signed-off-by: Miriam Rubio <mirucam@gmail.com> > --- > t/t6030-bisect-porcelain.sh | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/t/t6030-bisect-porcelain.sh b/t/t6030-bisect-porcelain.sh > index f41453cc97..99b7517400 100755 > --- a/t/t6030-bisect-porcelain.sh > +++ b/t/t6030-bisect-porcelain.sh > @@ -976,4 +976,11 @@ test_expect_success 'bisect run fails with exit code smaller than 0' ' > test_must_fail git bisect run ./test_script.sh > my_bisect_log.txt > ' > > +test_expect_success 'bisect visualize with a filename with dash and space' ' > + echo "My test line" >> -hello\ 2 && > + git add -- -hello\ 2 && > + git commit --quiet -m "Add test line" -- -hello\ 2 && > + git bisect visualize -p -- -hello\ 2 > my_bisect_log.txt > +' > + > test_done >
Seems like you're testing with filename with dash and space. Does git bisect visualize have any problems handling such filenames?
-- An old man doll... just what I always wanted! - Clara