git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v4 2/6] t6030-bisect-porcelain: add test for bisect visualize

From
Miriam R. <mirucam@gmail.com>
Date
Aug 17, 2021, 20:17 UTC
Message-ID
<CAN7CjDD8n-P0-UD4e1w0VPLc+CRnho47KcA_7xRs96Hu8CQeTA@mail.gmail.com>
In-Reply-To
<cca9771b-035e-0aca-bcf2-115f7af364e4@gmail.com>
Hi Bagas,

El mar, 17 ago 2021 a las 11:03, Bagas Sanjaya (<bagasdotme@gmail.com>) escribió:

Show 30 quoted lines
>
> On 17/08/21 15.14, Miriam Rubio wrote:
> > Add a test to control breakages in bisect visualize command.
> >
> > Signed-off-by: Miriam Rubio <mirucam@gmail.com>
> > ---
> >   t/t6030-bisect-porcelain.sh | 7 +++++++
> >   1 file changed, 7 insertions(+)
> >
> > diff --git a/t/t6030-bisect-porcelain.sh b/t/t6030-bisect-porcelain.sh
> > index f41453cc97..99b7517400 100755
> > --- a/t/t6030-bisect-porcelain.sh
> > +++ b/t/t6030-bisect-porcelain.sh
> > @@ -976,4 +976,11 @@ test_expect_success 'bisect run fails with exit code smaller than 0' '
> >       test_must_fail git bisect run ./test_script.sh > my_bisect_log.txt
> >   '
> >
> > +test_expect_success 'bisect visualize with a filename with dash and space' '
> > +     echo "My test line" >> -hello\ 2 &&
> > +     git add -- -hello\ 2 &&
> > +     git commit --quiet -m "Add test line" -- -hello\ 2 &&
> > +     git bisect visualize -p -- -hello\ 2 > my_bisect_log.txt
> > +'
> > +
> >   test_done
> >
>
> Seems like you're testing with filename with dash and space. Does git
> bisect visualize have any problems handling such filenames?
>

It was a suggestion of a reviewer in the previous version to detect possible breakages: https://lore.kernel.org/git/xmqq35vwh8qk.fsf@gitster.g/

Thanks for reviewing, Miriam

> --
> An old man doll... just what I always wanted! - Clara
Previous: Bagas SanjayaNext: Miriam Rubio
Message 8 of 20 in “Finish converting git bisect to C part 4”
  1. 0/6 Finish converting git bisect to C part 4Miriam Rubio, Aug 17, 2021
  2. 1/6 t6030-bisect-porcelain: add tests to control bisect run exit casesMiriam Rubio, Aug 17, 2021
  3. Bagas SanjayaAug 17, 2021
  4. Christian CouderAug 17, 2021
  5. Miriam R.Aug 17, 2021
  6. 2/6 t6030-bisect-porcelain: add test for bisect visualizeMiriam Rubio, Aug 17, 2021
  7. Bagas SanjayaAug 17, 2021
  8. Miriam R.Aug 17, 2021
  9. 3/6 run-command: make `exists_in_PATH()` non-staticMiriam Rubio, Aug 17, 2021
  10. 4/6 bisect--helper: reimplement `bisect_visualize()`shell function in CMiriam Rubio, Aug 17, 2021
  11. Johannes SchindelinAug 17, 2021
  12. Miriam R.Aug 17, 2021
  13. 5/6 bisect--helper: reimplement `bisect_run` shell function in CMiriam Rubio, Aug 17, 2021
  14. Johannes SchindelinAug 17, 2021
  15. Miriam R.Aug 17, 2021
  16. Johannes SchindelinAug 17, 2021
  17. Christian CouderAug 18, 2021
  18. Miriam R.Aug 18, 2021
  19. 6/6 bisect--helper: retire `--bisect-next-check` subcommandMiriam Rubio, Aug 17, 2021
  20. Johannes SchindelinAug 17, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.