Re: [PATCH v4 1/6] t6030-bisect-porcelain: add tests to control bisect run exit cases

From: Bagas Sanjaya <bagasdotme@gmail.com>
Date: Aug 17, 2021, 09:00 UTC
Message-ID: <3dcf28af-1e75-0934-4663-3691b0efde1d@gmail.com>
In-Reply-To: <20210817081458.53136-2-mirucam@gmail.com>

On 17/08/21 15.14, Miriam Rubio wrote:

Show 6 quoted lines

> +test_expect_success 'bisect run fails with exit code equals or greater than 128' '
> +	write_script test_script.sh <<-\EOF &&
> +	exit 128 >/dev/null
> +	EOF
> +	test_must_fail git bisect run ./test_script.sh > my_bisect_log.txt
> +'

This only checks for exit code equals to 128. You should also check for exit code greater than 128, for example 255.

Show 7 quoted lines

> +
> +test_expect_success 'bisect run fails with exit code smaller than 0' '
> +	write_script test_script.sh <<-\EOF &&
> +	exit -1 >/dev/null
> +	EOF
> +	test_must_fail git bisect run ./test_script.sh > my_bisect_log.txt
> +'

This test looks OK, using -1 as representative of negative exit code. However, wording of test name can also be 'bisect run fails with negative exit code'.

Thanks for reviewing.

-- 
An old man doll... just what I always wanted! - Clara