git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [RFC PATCH] GIT-VERSION-GEN: set --abbrev=9 to match auto-scaling

From
Ramsay Jones <ramsay@ramsayjones.plus.com>
Date
Dec 5, 2016, 22:42 UTC
Message-ID
<cbb39f75-dc3b-6bc7-9c60-9ce4e7d225f7@ramsayjones.plus.com>
In-Reply-To
<xmqqr35m2eva.fsf@gitster.mtv.corp.google.com>
On 05/12/16 22:24, Junio C Hamano wrote:
Show 17 quoted lines
> Ramsay Jones <ramsay@ramsayjones.plus.com> writes:
> 
>> As I said, the original version of the patch just removed the
>> --abbrev=7, but then I started to think about why you might have
>> used --abbrev in the first place (first in commit 9b88fcef7 and
>> again in commit bf505158d). Making sure to override the configuration
>> was the only thing I could come up with. So, I was hoping you could
>> remember why! :-P
> 
> Nope.  As a maintainer support script, the only thing I cared about
> it is that there is no -gXXXX at the end for anything I release ;-)
> 
>> (I assumed it was to force a measure of uniformity/reproducibility).
> 
> You cannot force uniformity/reproducibility with fixed abbrev,
> unless you set abbreviation length to 40, so you are correct to add
> "a measure of" there ;-)
Indeed. ;-)
Show 6 quoted lines
>                            The first choice (i.e. 4) may have had a
> justification to force absolute minimum, and the second one (i.e. 7)
> may have had a justifiation to make it clear that we are using the
> same setting as the default, so in post-1.7.10 era, I think it is
> fine for us to just say "we have been using the same as default, so
> let's not specify anything explicitly".
So, you would be happy with just removing the '--abbrev' argument?
(That's fine by me; I don't set core.abbrev!)

ATB, Ramsay Jones

Previous: Junio C HamanoNext: Junio C Hamano
Message 7 of 12 in “GIT-VERSION-GEN: set --abbrev=9 to match auto-scaling”
  1. GIT-VERSION-GEN: set --abbrev=9 to match auto-scalingRamsay Jones, Dec 4, 2016
  2. Jeff KingDec 5, 2016
  3. Ramsay JonesDec 5, 2016
  4. Junio C HamanoDec 5, 2016
  5. Ramsay JonesDec 5, 2016
  6. Junio C HamanoDec 5, 2016
  7. Ramsay JonesDec 5, 2016
  8. Junio C HamanoDec 5, 2016
  9. Jeff KingDec 6, 2016
  10. Junio C HamanoDec 6, 2016
  11. Jeff KingDec 6, 2016
  12. Ramsay JonesDec 6, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.