Re: [RFC PATCH] GIT-VERSION-GEN: set --abbrev=9 to match auto-scaling
- From
Jeff King <peff@peff.net>
- Date
- Dec 6, 2016, 18:26 UTC
- Message-ID
- <20161206182648.sxoftkd4hjhvenaf@sigill.intra.peff.net>
- In-Reply-To
- <xmqqwpfc2a7g.fsf@gitster.mtv.corp.google.com>
On Tue, Dec 06, 2016 at 10:17:55AM -0800, Junio C Hamano wrote:
Show 9 quoted lines
> Yup, that is what I meant to say with "that is already possible" and > we are on the same page. As all three of us seem to be happy with > just dropping --abbrev and letting describe do its default thing (as > configured by whoever is doing the build), let's do so. > > -- >8 -- > From: Ramsay Jones <ramsay@ramsayjones.plus.com> > Date: Sun, 4 Dec 2016 20:45:59 +0000 > Subject: [PATCH] GIT-VERSION-GEN: do not force abbreviation length used by 'describe'
Thanks, this is a nice summary of the discussion, and the patch is obviously correct.
-Peff