Re: [RFC PATCH] GIT-VERSION-GEN: set --abbrev=9 to match auto-scaling

From: Jeff King <peff@peff.net>
Date: Dec 5, 2016, 05:32 UTC
Message-ID: <20161205053258.jtnqq64gp5n7vtni@sigill.intra.peff.net>
In-Reply-To: <22e9dfa0-47fb-d6fd-caf4-c2d87f63f707@ramsayjones.plus.com>

On Sun, Dec 04, 2016 at 08:45:59PM +0000, Ramsay Jones wrote:

Show 17 quoted lines

> 
> Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
> ---
> 
> Hi Junio,
> 
> I recently noticed that:
> 
>     $ make >pout 2>&1
>     $ ./git version
>     git version 2.11.0.286.g109e8a9
>     $ git describe
>     v2.11.0-286-g109e8a99d
>     $
> 
> ... for non-release builds, the commit part of the version
> string was still using an --abbrev=7.

It seems like this kind of discussion ought to go in the commit message. :)

That said, I think the right patch may be to just drop --abbrev entirely. Its use goes all the way back to 9b88fcef7 (Makefile: use git-describe to mark the git version., 2005-12-27), where it was --abbrev=4. That became --abbrev=7 in bf505158d (Git 1.7.10.1, 2012-05-01) without further comment.

I think at that point it was a noop, as 7 should have been the default. And now we probably ought to drop it, so that we can use the auto-scaling default.

-Peff