git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: gitweb: buggy 'commitdiff_plain' output

From
Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
Date
Jul 10, 2009, 17:38 UTC
Message-ID
<cb7bb73a0907101038t10494806k64380a5e33f1bc16@mail.gmail.com>
In-Reply-To
<200907101933.39424.jnareb@gmail.com>
On Fri, Jul 10, 2009 at 7:33 PM, Jakub Narebski<jnareb@gmail.com> wrote:
> Actually the problem is deeper; both 'commitdiff' and 'commitdiff_plain'
> try to do two things at once: an equivalent of "git show <commit>" _and_
> equivalent of "git diff <commit 1> <commit 2>"... and they fail.

I think the time might have come to break backwards compatibility and fix commitdiff view once and for all ... of course we would have to choose HOW to fix it ...

For single commits, we could have commitdiff = commit + diff and commitdiff_plain = patch.

For multiple commits, we could have commitdiff(_plain) output a list of subjects for each commit involved, + the output of git diff.

How does that sound? (read?)
-- 
Giuseppe "Oblomov" Bilotta
Previous: Jakub NarebskiNext: Linus Torvalds
Message 3 of 6 in “gitweb: buggy 'commitdiff_plain' output”
  1. Linus TorvaldsJul 10, 2009
  2. Jakub NarebskiJul 10, 2009
  3. Giuseppe BilottaJul 10, 2009
  4. Linus TorvaldsJul 10, 2009
  5. Jakub NarebskiJul 10, 2009
  6. Giuseppe BilottaJul 10, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.