Re: gitweb: buggy 'commitdiff_plain' output

From: Jakub Narebski <jnareb@gmail.com>
Date: Jul 10, 2009, 21:50 UTC
Message-ID: <200907102350.15511.jnareb@gmail.com>
In-Reply-To: <alpine.LFD.2.01.0907101405480.3352@localhost.localdomain>

On Fri, 10 July 2009, Linus Torvalds wrote:

Show 18 quoted lines

> On Fri, 10 Jul 2009, Jakub Narebski wrote:
>> On Fri, 10 July 2009, Linus Torvalds wrote:
>>> 
>>> It turns out that that duplication is because they use gitweb as a strange 
>>> patch distribution system (rather than emailing each other patches), and 
>>> download the 'commitdiff_plain' version of the diff and then apply it with 
>>> 'git am -s'.
>> 
>> First question: do they use gitweb from git.git repository, or a custom
>> fork of gitweb (like git.kernel.org gitweb, which has caching, but IIRC
>> does not have all new gitweb features)?
> 
> I have no idea. Afaik, it was on samba.org:
> 
> 	http://git.samba.org/?p=jlayton/cifs.git;a=commitdiff_plain;h=acc11a88a4cb4ba16777099da00664347e0683f0
> 
> and I have no clue whether samba org uses plain git gitweb or something 
> fancier.

Thanks. It looks on first glance like ordinary gitweb, only old. It is git and gitweb version 1.5.4.3 from 23 Feb 2008, while Giuseppe's patches made it into git in v1.6.1 or v1.6.2 (commit is from 23 Dec 2008).

-- 
Jakub Narebski
Poland