From: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
Date: Fri, 10 Jul 2009 17:38:11 GMT
Subject: Re: gitweb: buggy 'commitdiff_plain' output
Message-ID: <cb7bb73a0907101038t10494806k64380a5e33f1bc16@mail.gmail.com>
In-Reply-To: <200907101933.39424.jnareb@gmail.com>

On Fri, Jul 10, 2009 at 7:33 PM, Jakub Narebski<jnareb@gmail.com> wrote:
> Actually the problem is deeper; both 'commitdiff' and 'commitdiff_plain'
> try to do two things at once: an equivalent of "git show <commit>" _and_
> equivalent of "git diff <commit 1> <commit 2>"... and they fail.

I think the time might have come to break backwards compatibility and
fix commitdiff view once and for all ... of course we would have to
choose HOW to fix it ...

For single commits, we could have commitdiff = commit + diff and
commitdiff_plain = patch.

For multiple commits, we could have commitdiff(_plain) output a list
of subjects for each commit involved, + the output of git diff.

How does that sound? (read?)

-- 
Giuseppe "Oblomov" Bilotta