git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCHv5 2/3] gitweb: add patches view

From
Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
Date
Dec 18, 2008, 19:57 UTC
Message-ID
<cb7bb73a0812181157r20b0cbc3t290e32454a435b0c@mail.gmail.com>
In-Reply-To
<200812181915.48556.jnareb@gmail.com>
On Thu, Dec 18, 2008 at 7:15 PM, Jakub Narebski <jnareb@gmail.com> wrote:
Show 7 quoted lines
>
> Just a though, but does it really take much sense to have "patch" and
> "patches" views handled in git_commitdiff? I can understand in the
> first version, where it was more about better 'commitdiff_plain', but
> I wonder about now, where patch(es) view is something between git show
> and log_plain format... Wouldn't it be simpler to use separate
> subroutine, for example git_format_patch or something?

I don't feel like much has changed since the beginning when IYO it made sense to have it part of commitdiff, honestly

-- 
Giuseppe "Oblomov" Bilotta
Previous: Jakub Narebski
Message 12 of 12 in “[PATCHv5 0/3] gitweb: patch view”
  1. Giuseppe BilottaDec 16, 2008
  2. 1/3 gitweb: add patch viewGiuseppe Bilotta, Dec 16, 2008
  3. 2/3 gitweb: add patches viewGiuseppe Bilotta, Dec 16, 2008
  4. 3/3 gitweb: link to patch(es) view in commit(diff) and (short)log viewGiuseppe Bilotta, Dec 16, 2008
  5. Junio C HamanoDec 18, 2008
  6. Jakub NarebskiDec 18, 2008
  7. Giuseppe BilottaDec 18, 2008
  8. Jakub NarebskiDec 18, 2008
  9. Junio C HamanoDec 18, 2008
  10. Jakub NarebskiDec 18, 2008
  11. Jakub NarebskiDec 18, 2008
  12. Giuseppe BilottaDec 18, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.