git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCHv5 2/3] gitweb: add patches view

From
Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
Date
Dec 16, 2008, 10:11 UTC
Message-ID
<1229422290-6213-3-git-send-email-giuseppe.bilotta@gmail.com>
In-Reply-To
<1229422290-6213-2-git-send-email-giuseppe.bilotta@gmail.com>

The only difference between patch and patches view is in the treatement of single commits: the former only displays a single patch, whereas the latter displays a patchset leading to the specified commit.

Signed-off-by: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
---
 gitweb/gitweb.perl |   16 +++++++++++++++-
 1 files changed, 15 insertions(+), 1 deletions(-)
diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index 1006dfe..e7a6477 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -530,6 +530,7 @@ our %actions = (
 	"history" => \&git_history,
 	"log" => \&git_log,
 	"patch" => \&git_patch,
+	"patches" => \&git_patches,
 	"rss" => \&git_rss,
 	"atom" => \&git_atom,
 	"search" => \&git_search,
@@ -5413,6 +5414,7 @@ sub git_blobdiff_plain {
 
 sub git_commitdiff {
 	my $format = shift || 'html';
+	my %params = @_;
 
 	my $patch_max;
 	if ($format eq 'patch') {
@@ -5529,7 +5531,15 @@ sub git_commitdiff {
 			}
 			push @commit_spec, '-n', "$hash_parent..$hash";
 		} else {
-			push @commit_spec, '-1', '--root', $hash;
+			if ($params{-single}) {
+				push @commit_spec, '-1';
+			} else {
+				if ($patch_max > 0) {
+					push @commit_spec, "-$patch_max";
+				}
+				push @commit_spec, "-n";
+			}
+			push @commit_spec, '--root', $hash;
 		}
 		open $fd, "-|", git_cmd(), "format-patch", '--encoding=utf8',
 			'--stdout', @commit_spec
@@ -5625,6 +5635,10 @@ sub git_commitdiff_plain {
 
 # format-patch-style patches
 sub git_patch {
+	git_commitdiff('patch', -single=> 1);
+}
+
+sub git_patches {
 	git_commitdiff('patch');
 }
 
-- 
1.5.6.5
Previous: Giuseppe BilottaNext: Giuseppe Bilotta
Message 3 of 12 in “[PATCHv5 0/3] gitweb: patch view”
  1. Giuseppe BilottaDec 16, 2008
  2. 1/3 gitweb: add patch viewGiuseppe Bilotta, Dec 16, 2008
  3. 2/3 gitweb: add patches viewGiuseppe Bilotta, Dec 16, 2008
  4. 3/3 gitweb: link to patch(es) view in commit(diff) and (short)log viewGiuseppe Bilotta, Dec 16, 2008
  5. Junio C HamanoDec 18, 2008
  6. Jakub NarebskiDec 18, 2008
  7. Giuseppe BilottaDec 18, 2008
  8. Jakub NarebskiDec 18, 2008
  9. Junio C HamanoDec 18, 2008
  10. Jakub NarebskiDec 18, 2008
  11. Jakub NarebskiDec 18, 2008
  12. Giuseppe BilottaDec 18, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.