From: Giuseppe Bilotta Date: Sun, 07 Dec 2008 09:52:38 GMT Subject: Re: [RFCv4 1/3] gitweb: add patch view Message-ID: In-Reply-To: <20081207060430.GE4357@ftbfs.org> On Sun, Dec 7, 2008 at 7:04 AM, Matt Kraai wrote: > Howdy, > > Why do you check $patch_max at the start of git_commitdiff instead of > at the start of hunk which opens git-format-patch? It seems like it > would be clearer to check it later, at some small loss of efficiency. Subsequent patches use the check to add a link to the nav bar, so it reduces code shift from patch to patch 8-) -- Giuseppe "Oblomov" Bilotta