git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCHv4] gitweb: parse project/action/hash_base:filename PATH_INFO

From
Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
Date
Oct 3, 2008, 05:54 UTC
Message-ID
<cb7bb73a0810022254v7dd3af5cwc315a2b4a67f10ba@mail.gmail.com>
In-Reply-To
<200810030041.54563.jnareb@gmail.com>
On Fri, Oct 3, 2008 at 12:41 AM, Jakub Narebski <jnareb@gmail.com> wrote:
Show 18 quoted lines
> Petr Baudis wrote:
>> On Thu, Oct 02, 2008 at 11:05:18PM +0200, Giuseppe Bilotta wrote:
>> >
>> > In preparing the new patchset, I've put a big comment block explaining
>> > why we need to set both $hash and $hash_base in this code-path:
>> >
>> > # we got "project.git/[action/]branch". in this case
>> > # we set both $hash and $hash_base because different actions
>> > # need one or the other to be set to behave correctly.
>> > #
>> > # For example, if $hash_base is not set then the blob and
>
> 'blob' without $file_name doesn't have sense, but 'tree' does.
> Probably should be s/blob/tree/ above.
>
>> > # history links on the page project.git/tree/somebranch will
>> > # assume a $hash_base of HEAD instead of the correct
>> > # somebranch.
Note: the blob and history links _in a tree page_ are wrong. The page
itself is correct.
What this means is that if you go to project.git/tree/somebranch you
get the correct list of files and directories for the project at
somebranch's HEAD, but all the links IN that page will point to the
wrong version, because they will have no $hash_base set and will thus
default to HEAD.

You can see this effect for example by going to http://repo.or.cz/w/git.git/v1.4.0?a=tree <- this hand-crafted path would never be generated by the old pathinfo code, but it show exactly what would happen with my pahtinfo code on http://repo.or.cz/w/git.git/tree/v1.4.0 if $hash_base wasn't set.

-- 
Giuseppe "Oblomov" Bilotta
Previous: Jakub NarebskiNext: Jakub Narebski
Message 30 of 34 in “[PATCHv4] gitweb: PATH_INFO support improvements”
  1. Giuseppe BilottaOct 2, 2008
  2. [PATCHv4] gitweb: parse project/action/hash_base:filename PATH_INFOGiuseppe Bilotta, Oct 2, 2008
  3. [PATCHv4] gitweb: refactor input parameters parse/validationGiuseppe Bilotta, Oct 2, 2008
  4. [PATCHv4] gitweb: generate project/action/hash URLsGiuseppe Bilotta, Oct 2, 2008
  5. [PATCHv4] gitweb: use_pathinfo filenames start with /Giuseppe Bilotta, Oct 2, 2008
  6. [PATCHv4] gitweb: parse parent..current syntax from pathinfoGiuseppe Bilotta, Oct 2, 2008
  7. [PATCHv4] gitweb: generate parent..current URLsGiuseppe Bilotta, Oct 2, 2008
  8. Jakub NarebskiOct 6, 2008
  9. Jakub NarebskiOct 4, 2008
  10. Giuseppe BilottaOct 4, 2008
  11. Jakub NarebskiOct 4, 2008
  12. Jakub NarebskiOct 5, 2008
  13. Jakub NarebskiOct 3, 2008
  14. Jakub NarebskiOct 3, 2008
  15. Jakub NarebskiOct 4, 2008
  16. Jakub NarebskiOct 3, 2008
  17. Giuseppe BilottaOct 3, 2008
  18. Jakub NarebskiOct 3, 2008
  19. Jakub NarebskiOct 2, 2008
  20. Giuseppe BilottaOct 2, 2008
  21. Jakub NarebskiOct 3, 2008
  22. Giuseppe BilottaOct 3, 2008
  23. Jakub NarebskiOct 3, 2008
  24. Petr BaudisOct 2, 2008
  25. Giuseppe BilottaOct 2, 2008
  26. Petr BaudisOct 2, 2008
  27. Giuseppe BilottaOct 2, 2008
  28. Petr BaudisOct 2, 2008
  29. Jakub NarebskiOct 2, 2008
  30. Giuseppe BilottaOct 3, 2008
  31. Jakub NarebskiOct 2, 2008
  32. Giuseppe BilottaOct 2, 2008
  33. Jakub NarebskiOct 2, 2008
  34. Jakub NarebskiOct 3, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.