Re: [PATCHv4] gitweb: use_pathinfo filenames start with /
- From
Jakub Narebski <jnareb@gmail.com>
- Date
- Oct 3, 2008, 11:28 UTC
- Message-ID
- <200810031328.33956.jnareb@gmail.com>
- In-Reply-To
- <1222906234-8182-5-git-send-email-giuseppe.bilotta@gmail.com>
On Thu, 2 Oct 2008, Giuseppe Bilotta wrote:
> When using path info, make filenames start with a / (right after the : > that separates them from the hash base). This minimal change allows > relative navigation to work properly when viewing HTML files.
...in 'raw' mode/'blob_plain' view.
This allows to for example view web site as it was at some revision, following relative links and checking if they are broken.
> > Signed-off-by: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
Acked-by: Jakub Narebski <jnareb@gmail.com>
(Note that it depends on previous patch, and without it doesn't make sense, so this Ack doesn't matter much now!)
Show 35 quoted lines
> ---
> gitweb/gitweb.perl | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
> index 2c380ac..3e5b2b7 100755
> --- a/gitweb/gitweb.perl
> +++ b/gitweb/gitweb.perl
> @@ -690,7 +690,7 @@ sub href (%) {
> # try to put as many parameters as possible in PATH_INFO:
> # - project name
> # - action
> - # - hash or hash_base:filename
> + # - hash or hash_base:/filename
>
> # Strip any trailing / from $href, or we might get double
> # slashes when the script is the DirectoryIndex
> @@ -708,11 +708,11 @@ sub href (%) {
> delete $params{'action'};
> }
>
> - # Finally, we put either hash_base:file_name or hash
> + # Finally, we put either hash_base:/file_name or hash
> if (defined $params{'hash_base'}) {
> $href .= "/".esc_url($params{'hash_base'});
> if (defined $params{'file_name'}) {
> - $href .= ":".esc_url($params{'file_name'});
> + $href .= ":/".esc_url($params{'file_name'});
> delete $params{'file_name'};
> }
> delete $params{'hash'};
> --
> 1.5.6.5
>
> -- Jakub Narebski Poland