git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCHv4] gitweb: PATH_INFO support improvements

From
Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
Date
Oct 2, 2008, 08:49 UTC
Message-ID
<cb7bb73a0810020149l4722be08p52be3b4703be0e41@mail.gmail.com>
In-Reply-To
<200810021019.27383.jnareb@gmail.com>
On Thu, Oct 2, 2008 at 10:19 AM, Jakub Narebski <jnareb@gmail.com> wrote:
Show 9 quoted lines
> Giuseppe Bilotta wrote:
>
>> Fourth version of my gitweb PATH_INFO patchset, whose purpose is to
>> reduce the use of CGI parameters by embedding as many parameters as
>> possible in the URL path itself, provided the pathinfo feature is
>> enabled.
>
> A nit: when sending longer patch series you should use numbered
> format in the form of [PATCH m/n] or [PATCH m/n vX] prefix.
W00t, I still manage to get this wrong. Kudos to me 8-/

I wonder why these options are not the default when there is more than one patch, btw?

(And yes, I tried looking into the builtin-log.c code but making it automatic is somewhat less trivial than I can dedicate time to.)

Show 10 quoted lines
>> The new typical gitweb URL is therefore in the form
>>
>> $project/$action/$parent:$file..$hash:$file
>>
>> (with useless parts stripped). Backwards compatibility for old-style
>> $project/$hash URLs is kept, as long as $hash is not a refname whose
>> name happens to match a git action.
>
> Minor nit: there was also old-style $project/$hash_base:$file_name
> path_info format.
Right, forgot about that.
Show 12 quoted lines
>> The main implementation is provided by paired patches (#1#3, #5#6)
>> that implement parsing and generation of the new style URLs.
>>
>> Patch #2 deals with a refactoring of the input parameters parsing and
>> validation, so that the rest of gitweb can be agnostic wrt to the
>> parameters' origin (CGI vs PATH_INFO vs possible other future inputs
>> such as CLI).
>>
>> Patch #4 is a minor improvement to the URL syntax that allows web
>> documents to be properly browsable in raw mode.
>
> Very nice summary of patchset and patch  coverage in this cover letter.

Thanks. At least I'm learning from my past errors. I'll manage to send the perfect patchset sooner or later ;)

-- 
Giuseppe "Oblomov" Bilotta
Previous: Jakub NarebskiNext: Jakub Narebski
Message 32 of 34 in “[PATCHv4] gitweb: PATH_INFO support improvements”
  1. Giuseppe BilottaOct 2, 2008
  2. [PATCHv4] gitweb: parse project/action/hash_base:filename PATH_INFOGiuseppe Bilotta, Oct 2, 2008
  3. [PATCHv4] gitweb: refactor input parameters parse/validationGiuseppe Bilotta, Oct 2, 2008
  4. [PATCHv4] gitweb: generate project/action/hash URLsGiuseppe Bilotta, Oct 2, 2008
  5. [PATCHv4] gitweb: use_pathinfo filenames start with /Giuseppe Bilotta, Oct 2, 2008
  6. [PATCHv4] gitweb: parse parent..current syntax from pathinfoGiuseppe Bilotta, Oct 2, 2008
  7. [PATCHv4] gitweb: generate parent..current URLsGiuseppe Bilotta, Oct 2, 2008
  8. Jakub NarebskiOct 6, 2008
  9. Jakub NarebskiOct 4, 2008
  10. Giuseppe BilottaOct 4, 2008
  11. Jakub NarebskiOct 4, 2008
  12. Jakub NarebskiOct 5, 2008
  13. Jakub NarebskiOct 3, 2008
  14. Jakub NarebskiOct 3, 2008
  15. Jakub NarebskiOct 4, 2008
  16. Jakub NarebskiOct 3, 2008
  17. Giuseppe BilottaOct 3, 2008
  18. Jakub NarebskiOct 3, 2008
  19. Jakub NarebskiOct 2, 2008
  20. Giuseppe BilottaOct 2, 2008
  21. Jakub NarebskiOct 3, 2008
  22. Giuseppe BilottaOct 3, 2008
  23. Jakub NarebskiOct 3, 2008
  24. Petr BaudisOct 2, 2008
  25. Giuseppe BilottaOct 2, 2008
  26. Petr BaudisOct 2, 2008
  27. Giuseppe BilottaOct 2, 2008
  28. Petr BaudisOct 2, 2008
  29. Jakub NarebskiOct 2, 2008
  30. Giuseppe BilottaOct 3, 2008
  31. Jakub NarebskiOct 2, 2008
  32. Giuseppe BilottaOct 2, 2008
  33. Jakub NarebskiOct 2, 2008
  34. Jakub NarebskiOct 3, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.