Re: [PATCH] diff: add ruby funcname pattern
- From
Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
- Date
- Aug 2, 2008, 11:50 UTC
- Message-ID
- <cb7bb73a0808020450h18cd3fdbn7a90e31e3274191b@mail.gmail.com>
- In-Reply-To
- <alpine.DEB.1.00.0808021336050.9611@pacific.mpi-cbg.de.mpi-cbg.de>
Hello,
On Sat, Aug 2, 2008 at 1:39 PM, Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:
> The funcname thing was introduced by us, in Git. I do not know if Davide > picked the changes up; at least for the merge stuff he seemed to be pretty > reluctant.
Ah, it's a Git-only thing? didn't know about that. I guess that knowing that git's libxdiff is already hacked up from the original means I can think more freely about hacking it up some more, if I can come up with a proper solution 8-)
Show 11 quoted lines
>> The matchit plugin for vim seems to manage (even user-defined) code >> blocks very well, even for multi-state blocks (if ... else ... end), >> using regexps; so maybe a reimplementation in C for libxdiff could be a >> solution. > > Bzzt. You say vi manages it with regexps, and then you go on and say that > you therefore do _not_ want to use a regexp? > > BTW having funcname calculation in C was shot down by Junio as being too > inflexible, as the user cannot add new languages without recompiling. > That's why we have regexps now.
Sorry, I think there's a misunderstanding here ... I have all intentions to use regexps. What I was planning on reimplementing in C was the way matchit uses the regexps to determine the blocks (because, obviously, it being a vim script means it's coded in vim's own langauge instead of C). The actual definitions for the start and end of the block would still be done via regexps. 8-)
-- Giuseppe "Oblomov" Bilotta