git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] diff: add ruby funcname pattern

From
Lee Marlow <lee.marlow@gmail.com>
Date
Aug 2, 2008, 15:37 UTC
Message-ID
<7968d7490808020837m57a7c48fjf40c0a715f7f39ce@mail.gmail.com>
In-Reply-To
<C871A30D-F2AF-4385-ABD4-C57F474D7F01@sb.org>
On Fri, Aug 1, 2008 at 11:47 PM, Kevin Ballard <kevin@sb.org> wrote:
Show 6 quoted lines
> On Aug 1, 2008, at 10:41 PM, Giuseppe Bilotta wrote:
>
>> On Sat, Aug 2, 2008 at 2:31 AM, Kevin Ballard <kevin@sb.org> wrote:
>
> I think it's far simpler to stick with class/module/def.
>
I agree with Kevin.

It's simpler and I'm not sure what value it would bring to show anonymous code blocks. The funcname is just to provide some additional context around the diff hunk, so you know where you are. What would be shown for an anonymous code block or proc in the diff? The module/class/method seems to provide the most useful context.

-Lee
Previous: Giuseppe Bilotta
Message 14 of 14 in “diff: add ruby funcname pattern”
  1. diff: add ruby funcname patternGiuseppe Bilotta, Jul 31, 2008
  2. Junio C HamanoAug 1, 2008
  3. Giuseppe BilottaAug 1, 2008
  4. Junio C HamanoAug 1, 2008
  5. Giuseppe BilottaAug 1, 2008
  6. Jeff KingAug 1, 2008
  7. Kevin BallardAug 2, 2008
  8. Junio C HamanoAug 2, 2008
  9. Giuseppe BilottaAug 2, 2008
  10. Kevin BallardAug 2, 2008
  11. Giuseppe BilottaAug 2, 2008
  12. Johannes SchindelinAug 2, 2008
  13. Giuseppe BilottaAug 2, 2008
  14. Lee MarlowAug 2, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.