Re: [PATCH] diff: add ruby funcname pattern

From: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
Date: Aug 1, 2008, 08:39 UTC
Message-ID: <cb7bb73a0808010139n69f6d59fl4702cf2b20a8159f@mail.gmail.com>
In-Reply-To: <7v4p65tadh.fsf@gitster.siamese.dyndns.org>

On Fri, Aug 1, 2008 at 10:20 AM, Junio C Hamano <gitster@pobox.com> wrote:

Show 9 quoted lines

> Well, I forgot to say but the above was soliciting third party review;
> original submitter does not count ;-)
>
> ... nah, I am just joking.
>
> All of the things you said in the message I am responding to are good
> background information.  It would have been nicer if it were part of the
> initial message, perhaps below the three dash lines, which would have
> avoided this extra exchange.

Yeah, I know, I'm sorry, I realized I should have written it there as I was replying to your email. I'll try to keep it in mind the next time I submit a patch :)

Show 5 quoted lines

> Thanks again for the patch.  Somewhere I heard that there are 10 Rubyista
> git users for every non Rubyista git user, so I am sure somebody would
> comment on your patch in a day or two.  Perhaps we might even get Python
> and Perl hunk patterns (although I suspect Perl people are happy with the
> default one we stole from GNU diff) to go with it ;-).

You know, I think the Ruby funcname would work pretty well with Python as well. Or something very similar. I'll try cooking up a patch for that too. (But I thought Python users used mercurial? 8-D)

-- 
Giuseppe "Oblomov" Bilotta