Re: [PATCH v3] userdiff.c & doc/gitattributes.txt: add Octave
- From
Johannes Sixt <j6t@kdbg.org>
- Date
- May 17, 2019, 19:47 UTC
- Message-ID
- <cb16942d-3e2e-d5b0-4eb8-25937cd9d573@kdbg.org>
- In-Reply-To
- <CALM0=-=2PBLm6+pQxUq5L2=8hEUh3nFFheFN=HhN5CUGj6Kfeg@mail.gmail.com>
Am 17.05.19 um 14:19 schrieb LI, BO XUAN:
Show 10 quoted lines
> On Fri, May 17, 2019 at 7:34 AM Junio C Hamano <gitster@pobox.com> wrote: >> >> Johannes Sixt <j6t@kdbg.org> writes: >> >>> I'd prefer to keep this list at the minimum necessary as long as it is >>> hard-coded in C. >> >> Yeah, I know that feeling. > > So do we reach a consensus? Should I merge the Octave rules into Matlab rules?
Yes, please, that would be very much appreciated. Bonus points if you add some test cases for the hunk header patterns to the t/t4018 directory.
-- Hannes