Re: [PATCH v3] userdiff.c & doc/gitattributes.txt: add Octave

From: Johannes Sixt <j6t@kdbg.org>
Date: May 16, 2019, 19:20 UTC
Message-ID: <262eb1d4-a898-c6d0-8e04-ce6c58eaa4e6@kdbg.org>
In-Reply-To: <xmqqlfz64uzw.fsf@gitster-ct.c.googlers.com>

Am 16.05.19 um 11:19 schrieb Junio C Hamano:

Show 11 quoted lines

> Johannes Sixt <j6t@kdbg.org> writes:
> 
>> In Matlab, is %%% followed by space at the beginning of a line
>> *commonly* used for something different? If I were to make a guess, I
>> would say no. If I'm right, it does not hurt to merge the Octave rules
>> into the Matlab rules.
> 
> That is true because we are not syntax-aware and error-highlighting
> text editor.  If we were, I'd suspect that your stance may probably
> be different.  But instead we apply these patterns to a program that
> is assumed to be correctly written.

Correct!

Show 8 quoted lines

> And from that point of view, I agree with you that it would not hurt
> to make the existing patterns for Matlab slightly more receptive so
> that a correctly written programs in either language would be matched
> appropriately.
> 
> But would it hurt to have two similar entries, with a clear
> description on how they are different, in our code there, given how
> infrequently individual entries have historically been updated?

Would it hurt? Probably not. Should we open the door for everybody's favorite dialect? Probably not, either.

See, we do not even have separate entries for C and C++. Heck, we don't have an XML entry, because the HTML entry is good enough, and there are probably many more XML users than Matlab and Octave users together.

I'd prefer to keep this list at the minimum necessary as long as it is hard-coded in C. I would take a different stance if this were some configuration file that we ship.

-- Hannes