Re: [PATCH] doc/gitattributes: add Octave

From: Philip Oakley <philipoakley@iee.org>
Date: May 10, 2019, 23:09 UTC
Message-ID: <c1bef9da-e588-233f-b2c9-ed2b9932d4e6@iee.org>
In-Reply-To: <20190510004715.29298-1-liboxuan@connect.hku.hk>

On 10/05/2019 01:47, Boxuan Li wrote:

Show 21 quoted lines

> `matlab` pattern is also suitable for source code
> in the GNU Octave language.
>
> Signed-off-by: Boxuan Li <liboxuan@connect.hku.hk>
> ---
>   Documentation/gitattributes.txt | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/gitattributes.txt b/Documentation/gitattributes.txt
> index 4fb20cd0e9..1b28381bda 100644
> --- a/Documentation/gitattributes.txt
> +++ b/Documentation/gitattributes.txt
> @@ -819,7 +819,7 @@ patterns are available:
>   
>   - `java` suitable for source code in the Java language.
>   
> -- `matlab` suitable for source code in the MATLAB language.
> +- `matlab` suitable for source code in the MATLAB/Octave language.
>   
>   - `objc` suitable for source code in the Objective-C language.
>

Looks good to me. Will help Octave users searching on their name for the Open Source variant of Matlab. -- Philip