Re: [PATCH v3 09/12] builtin/maintenance: fix locking race when packing refs and reflogs

From: Kristoffer Haugsbakk <kristofferhaugsbakk@fastmail.com>
Date: Jun 2, 2025, 10:03 UTC
Message-ID: <cab8e175-e977-41b1-b53d-6b9170c9e416@app.fastmail.com>
In-Reply-To: <20250602-b4-pks-maintenance-ref-lock-race-v3-9-587d44252dcb@pks.im>

On Mon, Jun 2, 2025, at 09:17, Patrick Steinhardt wrote:

> As explained in the preceding commit, git-gc(1) knows to detach only
> after it has already packed references and reflogs. This is done to

I’m a naïve reader. When I read this I immediately thought that reflogs can be packed now. But going by the last paragraph it is packed references and expired reflogs?

Show 8 quoted lines

> avoid racing around their respective lockfiles.
>
> Adapt git-maintenance(1) accordingly and run the "pack-refs" and
> "reflog-expire" tasks in the foreground. Note that the "gc" task has the
> same issue, but the fix is a bit more involved there and will thus be
> done in a subsequent commit.
>
> Signed-off-by: Patrick Steinhardt <ps@pks.im>