Re: [PATCH v3 09/12] builtin/maintenance: fix locking race when packing refs and reflogs

From: Patrick Steinhardt <ps@pks.im>
Date: Jun 3, 2025, 06:34 UTC
Message-ID: <aD6Xh8kKUu0Y7sr-@pks.im>
In-Reply-To: <cab8e175-e977-41b1-b53d-6b9170c9e416@app.fastmail.com>

On Mon, Jun 02, 2025 at 12:03:21PM +0200, Kristoffer Haugsbakk wrote:

Show 7 quoted lines

> On Mon, Jun 2, 2025, at 09:17, Patrick Steinhardt wrote:
> > As explained in the preceding commit, git-gc(1) knows to detach only
> > after it has already packed references and reflogs. This is done to
> 
> I’m a naïve reader.  When I read this I immediately thought that reflogs
> can be packed now.  But going by the last paragraph it is packed
> references and expired reflogs?

Yeah, I see how this is misleading. But indeed, it is packing refs and expiring reflogs. I've rephrased this locally, but if that's okay with you I'll hold off sending a new version for just this change.

Thanks!

Patrick