Re: [PATCH v4 00/12] builtin/maintenance: fix ref lock races when detaching

From: Derrick Stolee <stolee@gmail.com>
Date: Jun 5, 2025, 15:53 UTC
Message-ID: <4a8b02fc-09b1-4e7a-9b44-49a526b1da48@gmail.com>
In-Reply-To: <20250603-b4-pks-maintenance-ref-lock-race-v4-0-52f5cf7b7e99@pks.im>

On 6/3/2025 10:01 AM, Patrick Steinhardt wrote:

Show 11 quoted lines

> Hi,
> 
> this patch series fixes races around locking the "packed-refs" file when
> auto-maintenance decides to repack it. This issue has been reported e.g.
> via [1] and [2].
> 
> The root cause is that git-gc(1) used to know to detach _after_ having
> repacked references. As such, callers wouldn't continue with their thing
> until we have already packed refs, and thus the race does not exist
> there. git-maintenance(1) didn't have the same split though, so this
> patch series retrofits that logic.

Thanks for making these changes. I read this v4 and only found an opportunity to improve our docs relative to the more helpful errors around using --schedule and --task together. I sent a diff that could be squashed in or skipped.

Thanks, -Stolee