Re: [PATCH v2 7/7] unpack-trees: improve performance of next_cache_entry

From: Bagas Sanjaya <bagasdotme@gmail.com>
Date: Oct 6, 2021, 10:37 UTC
Message-ID: <ca698f10-9870-021e-766c-d52c51447545@gmail.com>
In-Reply-To: <aa963eefae75d41983201e24398bc5692267b91b.1633440057.git.gitgitgadget@gmail.com>

On 05/10/21 20.20, Victoria Dye via GitGitGadget wrote:

Show 8 quoted lines

> The `cache_bottom` must be preserved for the sparse index (see 17a1bb570b
> (unpack-trees: preserve cache_bottom, 2021-07-14)).  Therefore, to retain
> the benefit `cache_bottom` provides in non-sparse index cases, a separate
> `hint` position indicates the first position `next_cache_entry` should
> search, updated each execution with a new position.  The performance of `git
> reset -- does-not-exist` (testing the "worst case" in which all entries in
> the index are unpacked with `next_cache_entry`) is significantly improved
> for the sparse index case:

Did you mean `a separate `hint` ... should be searched`?

-- 
An old man doll... just what I always wanted! - Clara