Re: [PATCH v5 0/8] Sparse Index: integrate with reset

From: Elijah Newren <newren@gmail.com>
Date: Nov 20, 2021, 22:13 UTC
Message-ID: <CABPp-BEKEC74qx_KrZTLDdt_bsgAQhR9MhO9v9pTtVvFyjaX6A@mail.gmail.com>
In-Reply-To: <pull.1048.v5.git.1635345563.gitgitgadget@gmail.com>

Hi!

On Wed, Oct 27, 2021 at 7:39 AM Victoria Dye via GitGitGadget <gitgitgadget@gmail.com> wrote:

>
> This series integrates the sparse index with git reset and provides
> miscellaneous fixes and improvements to the command in sparse checkouts.

...

Show 17 quoted lines

> Changes since V3
> ================
>
>  * Replace git update-index --force-full-index with git reset update-folder1
>    -- folder1/a, remove introduction of new --force-full-index option
>    entirely, and add comment clarifying the intent of sparse-index is
>    expanded and converted back test
>  * Fix authorship on reset: preserve skip-worktree bit in mixed reset
>    (current patch fully replaces original patch, but metadata of the
>    original wasn't properly replaced)
>
>
> Changes since V4
> ================
>
>  * Update t1092 test 'checkout and reset (mixed)' to explicitly verify
>    differences between sparse and full checkouts

I apologize for my tardiness in reviewing your updated series. You have addressed all my feedback from v2 and things look really good. I had a couple small questions on patch 7.

As with my previous review, I kinda skipped over the last patch because I never figured out the cache_bottom stuff. I read it to see if there were any obvious mistakes to someone unfamiliar with that mechanism (i.e. me) but didn't see anything. I read over the earlier patches much more carefully.

Anyway, other than patch 7 -- where I only had a minor nit on the commit message plus two questions (which might result in no changes), the series looks good.