git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 3/3] pull: add --[no-]show-forced-updates passthrough

From
Derrick Stolee via GitGitGadget <gitgitgadget@gmail.com>
Date
Jun 18, 2019, 20:25 UTC
Message-ID
<c9479caf4c6aa099bd49ddb4153051f449feab4c.1560889525.git.gitgitgadget@gmail.com>
In-Reply-To
<pull.273.git.gitgitgadget@gmail.com>
From: Derrick Stolee <dstolee@microsoft.com>

The 'git fetch' command can avoid calculating forced updates, so allow users of 'git pull' to provide that option. This is particularly necessary when the advice to use '--no-show-forced-updates' is given at the end of the command.

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
---
 builtin/pull.c | 7 +++++++
 1 file changed, 7 insertions(+)
diff --git a/builtin/pull.c b/builtin/pull.c
index 9dd32a115b..f1eaf6e6ed 100644
--- a/builtin/pull.c
+++ b/builtin/pull.c
@@ -128,6 +128,7 @@ static char *opt_update_shallow;
 static char *opt_refmap;
 static char *opt_ipv4;
 static char *opt_ipv6;
+static int opt_show_forced_updates = -1;
 
 static struct option pull_options[] = {
 	/* Shared options */
@@ -240,6 +241,8 @@ static struct option pull_options[] = {
 	OPT_PASSTHRU('6',  "ipv6", &opt_ipv6, NULL,
 		N_("use IPv6 addresses only"),
 		PARSE_OPT_NOARG),
+	OPT_BOOL(0, "show-forced-updates", &opt_show_forced_updates,
+		 N_("check for forced-updates on all updated branches")),
 
 	OPT_END()
 };
@@ -549,6 +552,10 @@ static int run_fetch(const char *repo, const char **refspecs)
 		argv_array_push(&args, opt_ipv4);
 	if (opt_ipv6)
 		argv_array_push(&args, opt_ipv6);
+	if (opt_show_forced_updates > 0)
+		argv_array_push(&args, "--show-forced-updates");
+	else if (opt_show_forced_updates == 0)
+		argv_array_push(&args, "--no-show-forced-updates");
 
 	if (repo) {
 		argv_array_push(&args, repo);
-- 
gitgitgadget
Previous: Junio C HamanoNext: Derrick Stolee via GitGitGadget
Message 15 of 16 in “fetch: add --[no-]show-forced-updates”
  1. 0/3 fetch: add --[no-]show-forced-updatesDerrick Stolee via GitGitGadget, Jun 18, 2019
  2. 1/3 fetch: add --[no-]show-forced-updates argumentDerrick Stolee via GitGitGadget, Jun 18, 2019
  3. t5510-fetch: fix negated 'test_i18ngrep' invocationSZEDER Gábor, Jul 30, 2019
  4. SZEDER GáborJul 30, 2019
  5. Derrick StoleeJul 31, 2019
  6. 0/3 tests: run non-httpd-specific tests before sourcing 'lib-httpd.sh'SZEDER Gábor, Aug 1, 2019
  7. 1/3 t5510-fetch: run non-httpd-specific test before sourcing 'lib-httpd.sh'SZEDER Gábor, Aug 1, 2019
  8. Derrick StoleeAug 1, 2019
  9. 2/3 t5703: run all non-httpd-specific tests before sourcing 'lib-httpd.sh'SZEDER Gábor, Aug 1, 2019
  10. 3/3 tests: warn against appending non-httpd-specific tests at the endSZEDER Gábor, Aug 1, 2019
  11. SZEDER GáborAug 1, 2019
  12. Junio C HamanoAug 1, 2019
  13. SZEDER GáborAug 2, 2019
  14. Junio C HamanoAug 2, 2019
  15. 3/3 pull: add --[no-]show-forced-updates passthroughDerrick Stolee via GitGitGadget, Jun 18, 2019
  16. 2/3 fetch: warn about forced updates in branch listingDerrick Stolee via GitGitGadget, Jun 18, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.