git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] t5510-fetch: fix negated 'test_i18ngrep' invocation

From
Derrick Stolee <stolee@gmail.com>
Date
Jul 31, 2019, 10:35 UTC
Message-ID
<4305ddb1-304a-d2f1-7bb9-370ee8de7293@gmail.com>
In-Reply-To
<20190730214000.GT20404@szeder.dev>
On 7/30/2019 5:40 PM, SZEDER Gábor wrote:
Show 24 quoted lines
> On Tue, Jul 30, 2019 at 11:29:15PM +0200, SZEDER Gábor wrote:
>> The test '--no-show-forced-updates' in 't5510-fetch.sh' added in
>> cdbd70c437 (fetch: add --[no-]show-forced-updates argument,
>> 2019-06-18) runs '! test_i18ngrep ...'.  This is wrong, because when
>> running the test with GIT_TEST_GETTEXT_POISON=true, then
>> 'test_i18ngrep' is basically a noop and always returns with success,
>> the leading ! turns that into a failure, which then fails the test.
>>
>> Use 'test_i18ngrep ! ...' instead.
>>
>> This went unnoticed by our GETTEXT_POISON CI builds, because those
>> builds don't run this test case: in those builds we don't install
>> Apache, and this test comes after 't5510' sources 'lib-httpd.sh',
>> which, consequently, skips all the remaining tests, including this
>> one.
> 
> Hrm...  It looks like there is nothing httpd-specific in this test
> case, at all, so we could run it even if a webserver is not available.
> Moving this test case earlier in the script seems to confirm it, as it
> still succeeds.
> 
> However, I'm not really familiar with this
> '--[no-]show-forced-updates' option, and this is not the time to get
> up to speed, so I would let Derrick to decide and follow up...

I was about to recommend you move the test to before the check for the changes. I only put the test near the end as I normally don't want to insert into the middle of a test script. It makes sense to do so here.

Thanks, -Stolee

Previous: SZEDER GáborNext: SZEDER Gábor
Message 5 of 16 in “fetch: add --[no-]show-forced-updates”
  1. 0/3 fetch: add --[no-]show-forced-updatesDerrick Stolee via GitGitGadget, Jun 18, 2019
  2. 1/3 fetch: add --[no-]show-forced-updates argumentDerrick Stolee via GitGitGadget, Jun 18, 2019
  3. t5510-fetch: fix negated 'test_i18ngrep' invocationSZEDER Gábor, Jul 30, 2019
  4. SZEDER GáborJul 30, 2019
  5. Derrick StoleeJul 31, 2019
  6. 0/3 tests: run non-httpd-specific tests before sourcing 'lib-httpd.sh'SZEDER Gábor, Aug 1, 2019
  7. 1/3 t5510-fetch: run non-httpd-specific test before sourcing 'lib-httpd.sh'SZEDER Gábor, Aug 1, 2019
  8. Derrick StoleeAug 1, 2019
  9. 2/3 t5703: run all non-httpd-specific tests before sourcing 'lib-httpd.sh'SZEDER Gábor, Aug 1, 2019
  10. 3/3 tests: warn against appending non-httpd-specific tests at the endSZEDER Gábor, Aug 1, 2019
  11. SZEDER GáborAug 1, 2019
  12. Junio C HamanoAug 1, 2019
  13. SZEDER GáborAug 2, 2019
  14. Junio C HamanoAug 2, 2019
  15. 3/3 pull: add --[no-]show-forced-updates passthroughDerrick Stolee via GitGitGadget, Jun 18, 2019
  16. 2/3 fetch: warn about forced updates in branch listingDerrick Stolee via GitGitGadget, Jun 18, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.