git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] t5510-fetch: fix negated 'test_i18ngrep' invocation

From
SZEDER Gábor <szeder.dev@gmail.com>
Date
Jul 30, 2019, 21:29 UTC
Message-ID
<20190730212915.3509-1-szeder.dev@gmail.com>
In-Reply-To
<a4fe71618410bdb188b6850a61ec65e7b4da5897.1560889525.git.gitgitgadget@gmail.com>

The test '--no-show-forced-updates' in 't5510-fetch.sh' added in cdbd70c437 (fetch: add --[no-]show-forced-updates argument, 2019-06-18) runs '! test_i18ngrep ...'. This is wrong, because when running the test with GIT_TEST_GETTEXT_POISON=true, then 'test_i18ngrep' is basically a noop and always returns with success, the leading ! turns that into a failure, which then fails the test.

Use 'test_i18ngrep ! ...' instead.

This went unnoticed by our GETTEXT_POISON CI builds, because those builds don't run this test case: in those builds we don't install Apache, and this test comes after 't5510' sources 'lib-httpd.sh', which, consequently, skips all the remaining tests, including this one.

Signed-off-by: SZEDER Gábor <szeder.dev@gmail.com>
---
This is a minor issue in v2.23.0-rc0.
'git grep "! test_i18n"' shows no other similar cases.
 t/t5510-fetch.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/t/t5510-fetch.sh b/t/t5510-fetch.sh
index 139f7106f7..f2481de577 100755
--- a/t/t5510-fetch.sh
+++ b/t/t5510-fetch.sh
@@ -997,7 +997,7 @@ test_expect_success '--no-show-forced-updates' '
 	(
 		cd no-forced-update-clone &&
 		git fetch --no-show-forced-updates origin 2>output &&
-		! test_i18ngrep "(forced update)" output
+		test_i18ngrep ! "(forced update)" output
 	)
 '
 

-- 
2.22.0.926.g602b9a0287
Previous: Derrick Stolee via GitGitGadgetNext: SZEDER Gábor
Message 3 of 16 in “fetch: add --[no-]show-forced-updates”
  1. 0/3 fetch: add --[no-]show-forced-updatesDerrick Stolee via GitGitGadget, Jun 18, 2019
  2. 1/3 fetch: add --[no-]show-forced-updates argumentDerrick Stolee via GitGitGadget, Jun 18, 2019
  3. t5510-fetch: fix negated 'test_i18ngrep' invocationSZEDER Gábor, Jul 30, 2019
  4. SZEDER GáborJul 30, 2019
  5. Derrick StoleeJul 31, 2019
  6. 0/3 tests: run non-httpd-specific tests before sourcing 'lib-httpd.sh'SZEDER Gábor, Aug 1, 2019
  7. 1/3 t5510-fetch: run non-httpd-specific test before sourcing 'lib-httpd.sh'SZEDER Gábor, Aug 1, 2019
  8. Derrick StoleeAug 1, 2019
  9. 2/3 t5703: run all non-httpd-specific tests before sourcing 'lib-httpd.sh'SZEDER Gábor, Aug 1, 2019
  10. 3/3 tests: warn against appending non-httpd-specific tests at the endSZEDER Gábor, Aug 1, 2019
  11. SZEDER GáborAug 1, 2019
  12. Junio C HamanoAug 1, 2019
  13. SZEDER GáborAug 2, 2019
  14. Junio C HamanoAug 2, 2019
  15. 3/3 pull: add --[no-]show-forced-updates passthroughDerrick Stolee via GitGitGadget, Jun 18, 2019
  16. 2/3 fetch: warn about forced updates in branch listingDerrick Stolee via GitGitGadget, Jun 18, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.